You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Tanya-W (via GitHub)" <gi...@apache.org> on 2023/02/21 05:48:10 UTC
[GitHub] [doris] Tanya-W opened a new pull request, #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Tanya-W opened a new pull request, #16977:
URL: https://github.com/apache/doris/pull/16977
# Proposed changes
Issue Number: close (https://github.com/apache/doris/issues/16976)
## Problem summary
Actually, when `modifyTableAddOrDropInvertedIndices` no need write `logAlterJob` edit log, because write `logModifyTableAddOrDropInvertedIndices` is enough
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on PR #16977:
URL: https://github.com/apache/doris/pull/16977#issuecomment-1437894648
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16977:
URL: https://github.com/apache/doris/pull/16977#issuecomment-1438582009
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16977:
URL: https://github.com/apache/doris/pull/16977#issuecomment-1438219428
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.12 seconds
stream load tsv: 464 seconds loaded 74807831229 Bytes, about 153 MB/s
stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230221101955_clickbench_pr_101022.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "carlvinhust2012 (via GitHub)" <gi...@apache.org>.
carlvinhust2012 commented on code in PR #16977:
URL: https://github.com/apache/doris/pull/16977#discussion_r1112596351
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -2498,7 +2498,6 @@ public void modifyTableAddOrDropInvertedIndices(Database db, OlapTable olapTable
schemaChangeJob.setJobState(AlterJobV2.JobState.WAITING_TXN);
this.addAlterJobV2(schemaChangeJob);
LOG.debug("logAlterJob schemaChangeJob:{}", schemaChangeJob);
Review Comment:
you have removed the invoker of 'logAlterJob', may be the debug log also need to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on PR #16977:
URL: https://github.com/apache/doris/pull/16977#issuecomment-1438144228
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on a diff in pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on code in PR #16977:
URL: https://github.com/apache/doris/pull/16977#discussion_r1112599814
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -2498,7 +2498,6 @@ public void modifyTableAddOrDropInvertedIndices(Database db, OlapTable olapTable
schemaChangeJob.setJobState(AlterJobV2.JobState.WAITING_TXN);
this.addAlterJobV2(schemaChangeJob);
LOG.debug("logAlterJob schemaChangeJob:{}", schemaChangeJob);
Review Comment:
yes, the debug log also can be removed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "carlvinhust2012 (via GitHub)" <gi...@apache.org>.
carlvinhust2012 commented on PR #16977:
URL: https://github.com/apache/doris/pull/16977#issuecomment-1437926573
Add some test case will be more better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "carlvinhust2012 (via GitHub)" <gi...@apache.org>.
carlvinhust2012 commented on code in PR #16977:
URL: https://github.com/apache/doris/pull/16977#discussion_r1112596351
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -2498,7 +2498,6 @@ public void modifyTableAddOrDropInvertedIndices(Database db, OlapTable olapTable
schemaChangeJob.setJobState(AlterJobV2.JobState.WAITING_TXN);
this.addAlterJobV2(schemaChangeJob);
LOG.debug("logAlterJob schemaChangeJob:{}", schemaChangeJob);
Review Comment:
you have remove the invoker of 'logAlterJob', may be the debug log also need to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16977:
URL: https://github.com/apache/doris/pull/16977#issuecomment-1438582085
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] qidaye merged pull request #16977: [fix](alter inverted index) fix write edit log in replaymodifyTableAddOrDropInvertedIndices function
Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye merged PR #16977:
URL: https://github.com/apache/doris/pull/16977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org