[GitHub] [pulsar] eolivelli commented on a change in pull request #8564: [pulsar-broker] Fix topic policy update

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #8564:
URL: https://github.com/apache/pulsar/pull/8564#discussion_r523390675



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java
##########
@@ -102,6 +102,8 @@
     @Override
     public void setup() throws Exception {
         conf.setLoadBalancerEnabled(true);
+        conf.setTopicLevelPoliciesEnabled(true);
+        conf.setSystemTopicEnabled(true);

Review comment:
       This change is affecting all of the other tests in this file.
   Do we have some side effect?
   Are we going to use more and more resources for al the tests in this file?
   My question is more general, sometimes we enable feature in common setup utilities, with the possibility to alter the semantics of the other tests.
   
   Probably in this case there is no issue. Please clarify, I am still new to this suite of tests




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org