You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/28 00:52:49 UTC

[GitHub] reddycharan commented on issue #1281: Issue��#570: Introducing EntryLogManager.

reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-376723194
 
 
   Thanks @ivankelly for taking the effort to consider ways to refactor the code. But this class is in deep down in the stack and I'm hesitant to make big code churn. With my changes in this sub-task and subsequent sub-tasks I would like to abstract out the code/logic pertaining to singleentrylog/entrylogperledger and move it to the implementations of EntryLogManager, but leave the rest of the code as it is to have minimal code churn and more focus. Once things are in place, I can consider the refactoring aspect of these classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services