You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/03/03 23:20:07 UTC

[GitHub] [spark] hvanhovell commented on a diff in pull request #40272: [SPARK-42667][CONNECT] Spark Connect: newSession API

hvanhovell commented on code in PR #40272:
URL: https://github.com/apache/spark/pull/40272#discussion_r1125126775


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -344,7 +344,9 @@ class SparkSession private[sql] (
   // scalastyle:on
 
   def newSession(): SparkSession = {
-    throw new UnsupportedOperationException("newSession is not supported")
+    val newClient: SparkConnectClient =

Review Comment:
   Small nit. We could also implement `SparkConnectClient.copy()`. That way we don't have to expose as much of the client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org