[GitHub] [beam] reuvenlax commented on a change in pull request #16650: [BEAM-11971] Fix directrunner timer consistency

[GitBox <gi...@apache.org>]

reuvenlax commented on a change in pull request #16650:
URL: https://github.com/apache/beam/pull/16650#discussion_r796850452



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4085,7 +4085,8 @@ public void onTimer(OutputReceiver<Long> r) {
       ValidatesRunner.class,
       UsesStatefulParDo.class,
       UsesTimersInParDo.class,
-      UsesLoopingTimer.class
+      UsesLoopingTimer.class,
+      UsesStrictTimerOrdering.class

Review comment:
       Well yes, but _any_ use of timers + state implies UseStrictTimerOrdering (since otherwise the GC timer could fire early and cleanup state). It just so happens that the particular bug I'm fixing mostly occurs during looping timers.
   
   When it comes to test categories, I'm not sure how to make one imply the other. Ideally of course we should fix all runners, in which case we won't need any of these test categories.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org