[jira] [Commented] (FLINK-7514) fix BackPressureStatsTrackerITCase releasing buffers twice

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171706#comment-16171706 ] 

ASF GitHub Bot commented on FLINK-7514:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4591
  
    I'm wondering about the benefit here. The existing code guarantees that all buffers would be recycled in case of test failure; don't these changes allow a memory leak? Isn't `recycle()` safe anyway since it is a No-Op if called multiple times without `retain()`?


> fix BackPressureStatsTrackerITCase releasing buffers twice
> ----------------------------------------------------------
>
>                 Key: FLINK-7514
>                 URL: https://issues.apache.org/jira/browse/FLINK-7514
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{BackPressureStatsTrackerITCase#testBackPressuredProducer()}} is releasing its buffers twice which should be fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)