You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/04 21:26:46 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25545: Coorect branch used for non-main builds
potiuk opened a new pull request, #25545:
URL: https://github.com/apache/airflow/pull/25545
Shell parameters should determine the branch based on environment
variables so that main version of Breeze can properly build images
in build-images.yml workflow.
While CI/PROD params were ok, Shell Param was always using main
and this failed PRs to v2-3-stable/test.
This PR unifies branch selection to use env variables (which are
properly set in CI).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25545: Coorect branch used for non-main builds
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25545:
URL: https://github.com/apache/airflow/pull/25545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25545: Coorect branch used for non-main builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25545:
URL: https://github.com/apache/airflow/pull/25545#issuecomment-1205786542
Last thing to make non-brain PRs to work (will be useful for 2.4 branch when we have it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25545: Coorect branch used for non-main builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25545:
URL: https://github.com/apache/airflow/pull/25545#issuecomment-1205798535
This is why https://github.com/apache/airflow/runs/7680474284?check_suite_focus=true failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org