You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2024/04/25 23:50:22 UTC
[PR] HDDS-10756. Avoid proto2 ByteString#copyFrom(byte[]). [ozone]
szetszwo opened a new pull request, #6592:
URL: https://github.com/apache/ozone/pull/6592
## What changes were proposed in this pull request?
As the name implied, `ByteString#copyFrom(byte[])` creates a ByteString by copying the given byte array. In some cases (e.g. the byte array is already copied), the copying can be avoided by using `Proto2Utils.unsafeByteString(byte[])`.
## What is the link to the Apache JIRA
HDDS-10756
## How was this patch tested?
By existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10756. Avoid proto2 ByteString#copyFrom(byte[]). [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #6592:
URL: https://github.com/apache/ozone/pull/6592#issuecomment-2081557690
@adoroszlai , thanks a lot for reviewing and merging this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10756. Avoid proto2 ByteString#copyFrom(byte[]). [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #6592:
URL: https://github.com/apache/ozone/pull/6592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org