You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/04 20:21:28 UTC
[jclouds-labs-google] Another cleanup of GCS. (#79)
more broken window fixing. PS we need to be more consistent with GCS vs GoogleCloudStorage!
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.gcs-cleanup-3
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/79
-- Commit Summary --
* Another cleanup of GCS.
-- File Changes --
R google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageFallbacks.java (22)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java (9)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java (11)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiExpectTest.java (7)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java (14)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/79.patch
https://github.com/jclouds/jclouds-labs-google/pull/79.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/79
Re: [jclouds-labs-google] Another cleanup of GCS. (#79)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #220](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/220/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/79#issuecomment-61698271
Re: [jclouds-labs-google] Another cleanup of GCS. (#79)
Posted by Adrian Cole <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/79#issuecomment-61843095
Re: [jclouds-labs-google] Another cleanup of GCS. (#79)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #1625](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1625/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/79#issuecomment-61699987
Re: [jclouds-labs-google] Another cleanup of GCS. (#79)
Posted by Adrian Cole <no...@github.com>.
> @@ -154,7 +155,7 @@ GCSObject getObject(@PathParam("bucket") String bucketName, @PathParam("object")
> @ResponseParser(ParseToPayloadEnclosing.class)
> @Fallback(NullOnNotFoundOr404.class)
> @Nullable
> - PayloadEnclosingImpl download(@PathParam("bucket") String bucketName, @PathParam("object") String objectName);
> + PayloadEnclosing download(@PathParam("bucket") String bucketName, @PathParam("object") String objectName);
@demobox fyi I think somehow this provider got through without decent review. needs a big once-over
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/79/files#r19884953