You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2018/02/06 23:59:16 UTC
[2/3] [math] MATH-1449: updating unit test syntax based on code review
MATH-1449: updating unit test syntax based on code review
Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/53a0a9ff
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/53a0a9ff
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/53a0a9ff
Branch: refs/heads/master
Commit: 53a0a9ff85666348a38054e335f5b4c5355a6419
Parents: 0e9f604
Author: darkma773r <ma...@hotmail.com>
Authored: Mon Feb 5 21:02:07 2018 -0500
Committer: darkma773r <ma...@hotmail.com>
Committed: Mon Feb 5 21:02:07 2018 -0500
----------------------------------------------------------------------
.../euclidean/twod/PolygonsSetTest.java | 26 +++++++++++---------
1 file changed, 14 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-math/blob/53a0a9ff/src/test/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSetTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSetTest.java b/src/test/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSetTest.java
index 4584d03..94a7157 100644
--- a/src/test/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSetTest.java
+++ b/src/test/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSetTest.java
@@ -229,8 +229,8 @@ public class PolygonsSetTest {
Assert.assertEquals(0.0, poly.getSize(), 1e-10);
Assert.assertEquals(0.0, poly.getBoundarySize(), 1e-10);
Assert.assertEquals(0, poly.getVertices().length);
- Assert.assertEquals(true, poly.isEmpty());
- Assert.assertEquals(false, poly.isFull());
+ Assert.assertTrue(poly.isEmpty());
+ Assert.assertFalse(poly.isFull());
GeometryTestUtils.assertVectorEquals(Cartesian2D.NaN, (Cartesian2D) poly.getBarycenter(), 1e-10);
checkPoints(Region.Location.OUTSIDE, poly, new Cartesian2D[] {
@@ -238,12 +238,12 @@ public class PolygonsSetTest {
Cartesian2D.ZERO,
new Cartesian2D(Double.POSITIVE_INFINITY, Double.POSITIVE_INFINITY)});
-
+ double offset;
for (double y = -1; y < 1; y += 0.1) {
for (double x = -1; x < 1; x += 0.1) {
- Assert.assertEquals(Double.POSITIVE_INFINITY,
- poly.projectToBoundary(new Cartesian2D(x, y)).getOffset(),
- 1.0e-10);
+ offset = poly.projectToBoundary(new Cartesian2D(x, y)).getOffset();
+ Assert.assertTrue(offset > 0);
+ Assert.assertTrue(Double.isInfinite(offset));
}
}
}
@@ -255,11 +255,12 @@ public class PolygonsSetTest {
// assert
Assert.assertEquals(1e-10, poly.getTolerance(), Precision.EPSILON);
- Assert.assertEquals(Double.POSITIVE_INFINITY, poly.getSize(), 1e-10);
+ Assert.assertTrue(poly.getSize() > 0);
+ Assert.assertTrue(Double.isInfinite(poly.getSize()));
Assert.assertEquals(0.0, poly.getBoundarySize(), 1e-10);
Assert.assertEquals(0, poly.getVertices().length);
- Assert.assertEquals(false, poly.isEmpty());
- Assert.assertEquals(true, poly.isFull());
+ Assert.assertFalse(poly.isEmpty());
+ Assert.assertTrue(poly.isFull());
GeometryTestUtils.assertVectorEquals(Cartesian2D.NaN, (Cartesian2D) poly.getBarycenter(), 1e-10);
checkPoints(Region.Location.INSIDE, poly, new Cartesian2D[] {
@@ -267,11 +268,12 @@ public class PolygonsSetTest {
Cartesian2D.ZERO,
new Cartesian2D(Double.POSITIVE_INFINITY, Double.POSITIVE_INFINITY)});
+ double offset;
for (double y = -1; y < 1; y += 0.1) {
for (double x = -1; x < 1; x += 0.1) {
- Assert.assertEquals(Double.NEGATIVE_INFINITY,
- poly.projectToBoundary(new Cartesian2D(x, y)).getOffset(),
- 1e-10);
+ offset = poly.projectToBoundary(new Cartesian2D(x, y)).getOffset();
+ Assert.assertTrue(offset < 0);
+ Assert.assertTrue(Double.isInfinite(offset));
}
}
}