You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Stephen Green (JIRA)" <ji...@apache.org> on 2010/08/16 21:08:27 UTC
[jira] Created: (SOLR-2052) Allow for a list of filter queries and
a single docset filter in QueryComponent
Allow for a list of filter queries and a single docset filter in QueryComponent
-------------------------------------------------------------------------------
Key: SOLR-2052
URL: https://issues.apache.org/jira/browse/SOLR-2052
Project: Solr
Issue Type: Improvement
Components: search
Affects Versions: 1.4.1
Environment: Mac OS X, Java 1.6
Reporter: Stephen Green
Priority: Minor
Fix For: 1.4.2
SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both. This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query. It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2052) Allow for a list of filter queries
and a single docset filter in QueryComponent
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928791#action_12928791 ]
Otis Gospodnetic commented on SOLR-2052:
----------------------------------------
Looks straight forward, but doesn't apply any more.
$ patch -p0 -i SOLR-2052-2.patch --dry-run
patching file src/java/org/apache/solr/search/SolrIndexSearcher.java
Hunk #1 succeeded at 1119 (offset 219 lines).
Hunk #2 succeeded at 1243 (offset 219 lines).
Hunk #3 succeeded at 1835 (offset 235 lines).
Hunk #4 succeeded at 1843 (offset 235 lines).
Hunk #5 succeeded at 1856 (offset 235 lines).
patching file src/java/org/apache/solr/handler/component/ResponseBuilder.java
Hunk #2 succeeded at 58 (offset 2 lines).
Hunk #3 succeeded at 223 (offset 41 lines).
Hunk #4 FAILED at 282.
1 out of 4 hunks FAILED -- saving rejects to file src/java/org/apache/solr/handler/component/ResponseBuilder.java.rej
> Allow for a list of filter queries and a single docset filter in QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: SOLR-2052-2.patch, SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both. This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query. It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2052) Allow for a list of filter queries
and a single docset filter in QueryComponent
Posted by "Stephen Green (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930165#action_12930165 ]
Stephen Green commented on SOLR-2052:
-------------------------------------
Thanks for taking a look, Otis. I'm in CA this week, but I should have a chance to fix the patch when I'm back home.
> Allow for a list of filter queries and a single docset filter in QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: SOLR-2052-2.patch, SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both. This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query. It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2052) Allow for a list of filter queries and
a single docset filter in QueryComponent
Posted by "Stephen Green (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Green updated SOLR-2052:
--------------------------------
Affects Version/s: 4.0
(was: 1.4.1)
> Allow for a list of filter queries and a single docset filter in QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both. This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query. It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2052) Allow for a list of filter queries and
a single docset filter in QueryComponent
Posted by "Stephen Green (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Green updated SOLR-2052:
--------------------------------
Attachment: SOLR-2052-2.patch
Updated patch that fixes a bug when combining filter docsets and filter queries.
> Allow for a list of filter queries and a single docset filter in QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: SOLR-2052-2.patch, SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both. This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query. It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2052) Allow for a list of filter queries and
a single docset filter in QueryComponent
Posted by "Stephen Green (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Green updated SOLR-2052:
--------------------------------
Attachment: SOLR-2052.patch
Patch for SolrIndexSearcher and ResponseBuilder. Passes ant clean test with no errors.
> Allow for a list of filter queries and a single docset filter in QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4.1
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both. This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query. It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org