You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/10/29 20:12:08 UTC
[jira] Created: (MPARTIFACT-41) HttpDeployer is not "port aware"
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPARTIFACT-41
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPARTIFACT-41
Summary: HttpDeployer is not "port aware"
Type: Bug
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-artifact-plugin
Assignee:
Reporter: Matthew Daniel
Created: Fri, 29 Oct 2004 2:11 PM
Updated: Fri, 29 Oct 2004 2:11 PM
Environment: cvs maven-plugins (HEAD)
Description:
As seen in CVS HEAD:
http://cvs.apache.org/viewcvs.cgi/maven-plugins/artifact/src/main/org/apache/maven/deploy/deployers/HttpDeployer.java?view=markup
The current version is not aware of a port number in the Repository's URL. It just passes it blindly into commons-httpclient's HostConfiguration, who assumes it to be a hostname.
Currently the code is:
hc.setHost(repoInfo.getHost());
I feel it should be:
String host = repoInfo.getHost();
int colonIdx = host.indexOf(':');
if (-1 != colonIdx) {
// with appropriate try-catch for NFE
int port = Integer.parseInt(
host.substring(colonIdx+1));
hc.setHost(host.substring(0, colonIdx));
hc.setPort(port);
}else {
hc.setHost(host);
}
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPARTIFACT-41) HttpDeployer is not "port aware"
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Brett Porter (mailto:brett@codehaus.org)
Date: Fri, 29 Oct 2004 9:14 PM
Changes:
Fix Version changed to 1.4.2
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPARTIFACT-41?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPARTIFACT-41
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPARTIFACT-41
Summary: HttpDeployer is not "port aware"
Type: Bug
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-artifact-plugin
Fix Fors:
1.4.2
Assignee:
Reporter: Matthew Daniel
Created: Fri, 29 Oct 2004 2:11 PM
Updated: Fri, 29 Oct 2004 9:14 PM
Environment: cvs maven-plugins (HEAD)
Description:
As seen in CVS HEAD:
http://cvs.apache.org/viewcvs.cgi/maven-plugins/artifact/src/main/org/apache/maven/deploy/deployers/HttpDeployer.java?view=markup
The current version is not aware of a port number in the Repository's URL. It just passes it blindly into commons-httpclient's HostConfiguration, who assumes it to be a hostname.
Currently the code is:
hc.setHost(repoInfo.getHost());
I feel it should be:
String host = repoInfo.getHost();
int colonIdx = host.indexOf(':');
if (-1 != colonIdx) {
// with appropriate try-catch for NFE
int port = Integer.parseInt(
host.substring(colonIdx+1));
hc.setHost(host.substring(0, colonIdx));
hc.setPort(port);
}else {
hc.setHost(host);
}
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPARTIFACT-41) HttpDeployer is not "port aware"
Posted by ji...@codehaus.org.
Message:
The following issue has been closed.
Resolver: Brett Porter
Date: Sat, 19 Feb 2005 9:07 PM
fixed in Wagon
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPARTIFACT-41
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPARTIFACT-41
Summary: HttpDeployer is not "port aware"
Type: Bug
Status: Closed
Priority: Major
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-artifact-plugin
Fix Fors:
1.5
Assignee:
Reporter: Matthew Daniel
Created: Fri, 29 Oct 2004 2:11 PM
Updated: Sat, 19 Feb 2005 9:07 PM
Environment: cvs maven-plugins (HEAD)
Description:
As seen in CVS HEAD:
http://cvs.apache.org/viewcvs.cgi/maven-plugins/artifact/src/main/org/apache/maven/deploy/deployers/HttpDeployer.java?view=markup
The current version is not aware of a port number in the Repository's URL. It just passes it blindly into commons-httpclient's HostConfiguration, who assumes it to be a hostname.
Currently the code is:
hc.setHost(repoInfo.getHost());
I feel it should be:
String host = repoInfo.getHost();
int colonIdx = host.indexOf(':');
if (-1 != colonIdx) {
// with appropriate try-catch for NFE
int port = Integer.parseInt(
host.substring(colonIdx+1));
hc.setHost(host.substring(0, colonIdx));
hc.setPort(port);
}else {
hc.setHost(host);
}
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org