[GitHub] [incubator-druid] leventov commented on a change in pull request #5418: More error reporting and stats for ingestion tasks

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #5418: More error reporting and stats for ingestion tasks
URL: https://github.com/apache/incubator-druid/pull/5418#discussion_r286899660
 
 

 ##########
 File path: indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java
 ##########
 @@ -508,12 +765,21 @@ private static ShardSpecs createShardSpecsFromInput(
               hllCollectors.put(interval, Optional.absent());
             }
           }
+          determinePartitionsFireDepartmentMetrics.incrementProcessed();
         }
         catch (ParseException e) {
-          if (ingestionSchema.getTuningConfig().isReportParseExceptions()) {
-            throw e;
-          } else {
-            unparseable++;
 
 Review comment:
   This change makes the `if (parseable > 0)` below dead. See #7737.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org