[GitHub] [helix] qqu0127 commented on a diff in pull request #2073: Fix race condition between instance drop and participant history update

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2073:
URL: https://github.com/apache/helix/pull/2073#discussion_r862125746


##########
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java:
##########
@@ -514,7 +515,7 @@ public void disconnect() {
     try {
       ParticipantHistory history = getHistory();
       history.reportOffline();
-      persistHistory(history);
+      persistHistory(history, true);

Review Comment:
   Chatted offline, here skipOnEmptyPath=true is the expected behavior.
   Updated for BaseControllerDataProvider.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org