[GitHub] [spark] zhengruifeng commented on a diff in pull request #37184: [SPARK-39772][SQL] namespace should not contain null to avoid potential serde problem

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #37184:
URL: https://github.com/apache/spark/pull/37184#discussion_r920843577


##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala:
##########
@@ -98,23 +98,22 @@ class Table(
     val isTemporary: Boolean)
   extends DefinedByConstructorParams {
 
+  if (namespace != null) {
+    assert(namespace.forall(_ != null))
+  }
+
   def this(
       name: String,
       database: String,
       description: String,
       tableType: String,
       isTemporary: Boolean) = {
-    this(name, null, Array(database), description, tableType, isTemporary)
+    this(name, null, if (database != null) Array(database) else null,

Review Comment:
   ok, let me clarify the title and description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org