You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/16 13:44:06 UTC

[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #207: [YUNIKORN-405] Added checksum validation

kingamarton commented on a change in pull request #207:
URL: https://github.com/apache/incubator-yunikorn-core/pull/207#discussion_r544308236



##########
File path: pkg/common/configs/config.go
##########
@@ -35,7 +36,7 @@ import (
 // set of scheduler resources.
 type SchedulerConfig struct {
 	Partitions []PartitionConfig
-	Checksum   [32]byte `yaml:"-" json:"-"`
+	Checksum   string `yaml:",omitempty" json:",omitempty"`

Review comment:
       I agree that it is a bit strange, but if we would introduce a new `UpdateChecksum` that will be weird as well, because we will have to hack around the marshalling part. Also I can image that it may confuse the users as well, because while creating the input for the request it seems natural to extend it with `Checksum: .....`, how the getConfig is returning it, instead of changing it to `UpdateChecksum: ....`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org