You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2023/08/06 16:20:00 UTC
[jira] [Closed] (MSITE-971) Site generation not resolving git.commit.time
[ https://issues.apache.org/jira/browse/MSITE-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Osipov closed MSITE-971.
--------------------------------
Resolution: Fixed
Fixed with MSITE-973.
> Site generation not resolving git.commit.time
> ---------------------------------------------
>
> Key: MSITE-971
> URL: https://issues.apache.org/jira/browse/MSITE-971
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 4.0.0-M9
> Environment: Windows 10 and FreeBSD
> Reporter: Brad Larrick
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 4.0.0-M10
>
>
> I'm using git-commit-id-maven-plugin to set project.build.outputTimestamp as suggested in the Maven Guide Configuring for Reproducible Builds. I've included the plugin in my pom and including the following property definition:
>
> {code:java}
> <project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>{code}
>
> When I generate the site, the plugin fails with the message:
> {{site failed: Invalid project.build.outputTimestamp value '${git.commit.time}}}
> This configuration works properly in the maven-jar-plugin, so I did some investigation. The jar plugin is getting the outputTimestamp as a mojo parameter:
>
> {code:java}
> @Parameter( defaultValue = "${project.build.outputTimestamp}" )
> private String outputTimestamp;
> {code}
> This works properly, with outputTimestamp set to the last commit time.
> In the site-plugin code, the outputTimestamp is being pulled from the project properties:
> {code:java}
> String outputTimestamp = p.getProperties().getProperty("project.build.outputTimestamp");{code}
> In the case the property hasn't been resolved and the returned string is ${git.commit.time}.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)