[GitHub] [flink] dawidwys commented on a change in pull request #18405: [FLINK-25683][streaming-java] wrong result if table transfrom to Data…

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #18405:
URL: https://github.com/apache/flink/pull/18405#discussion_r788410349



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -323,7 +323,9 @@ protected boolean isUsingCustomRawKeyedState() {
     public void open() throws Exception {}

Review comment:
       Could you please change the `AbstractStreamOperatorV2` as well?

##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -323,7 +323,9 @@ protected boolean isUsingCustomRawKeyedState() {
     public void open() throws Exception {}
 
     @Override
-    public void finish() throws Exception {}
+    public void finish() throws Exception {
+        setCurrentKey(EndOfDataKey.INSTANCE);

Review comment:
       Why don't you use `null`? This must not work as the `EndOfDataKey` is not of the same type as user's key.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org