You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tim Thorpe <tt...@ca.ibm.com> on 2016/03/22 19:41:02 UTC

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/
-----------------------------------------------------------

(Updated March 22, 2016, 6:40 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-15388
    https://issues.apache.org/jira/browse/AMBARI-15388


Repository: ambari


Description
-------

Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.

There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/45169/diff/


Testing
-------

Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.

This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.


Thanks,

Tim Thorpe


Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

Posted by Tim Thorpe <tt...@ca.ibm.com>.

> On March 29, 2016, 12:49 p.m., Nate Cole wrote:
> > I think you need a more concrete way of ordering here.  What if two services are marked as <after> YARN?  Which one takes precedence?  You may want to introduce an <service name="FALCON" order="1.0" /> in order to specifically state how it happens.  Order would be a float, such that if we have a 1.0 and a 2.0, and some service goes in between, then we don't need to reorder the world (just use 1.5, or 1.1 or whatever).
> > 
> > In addition, if you are making separate files, it's conceivable that config changes for services can go directly in their respective files.  We broke them up to separate church-and-state, if you will.
> > 
> > It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
> 
> Jayush Luniya wrote:
>     RE: It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
>     +1 on allowing add-on/custom service to extend stack upgrade packs instead of breaking down the entire upgrade pack to service level.

We decided we wouldn't split the upgrade xml into pieces for all the stack services.  Instead the goal will be limited to allow custom services to integrate into the upgrade process by providing their own service upgrade xml which will define their prereqs, order and process.  This means we still need a way for a service to indicate when during the process each of its steps needs to be done.

I am a bit leary of the order number because there are actually two ways that service steps need to get added.  (In the example below I will still use core services to demonstrate).

The first case is where a service needs to get integrated into an exists step.  In the example below, a service (HBASE) needs to be backed up prior to upgrade:

    <group xsi:type="cluster" name="PREPARE_BACKUPS" title="Prepare Backups">
      <after>KNOX</after>
      <execute-stage service="HBASE" component="HBASE_MASTER" title="Pre Upgrade HBase Backup">
        <task xsi:type="execute" hosts="master">
          <script>scripts/hbase_upgrade.py</script>
          <function>take_snapshot</function>
        </task>
      </execute-stage>
    </group>

The second case is where a service has a new step which just needs to be included in the order.  In the example below, a service (KNOX) needs a new step added:

    <group name="KNOX" title="Knox">
      <after>KAFKA</after>
      <skippable>true</skippable>
      <service name="KNOX">
        <component>KNOX_GATEWAY</component>
      </service>
    </group>
    
Nate proposed using an order number but this gets messy in the case of integrating into an existing step.  There would be 2 order numbers, one for the group and the other for the execute-stage:

    <group xsi:type="cluster" name="PREPARE_BACKUPS" title="Prepare Backups" order="2">
      <execute-stage service="HBASE" component="HBASE_MASTER" title="Pre Upgrade HBase Backup" order="2.35">
        <task xsi:type="execute" hosts="master">
          <script>scripts/hbase_upgrade.py</script>
          <function>take_snapshot</function>
        </task>
      </execute-stage>
    </group>
    
This seems a bit confusing.  It would also require changes to the actual upgrade xml when now we would otherwise not require any changes to those files.  Using a tag like <after>, does allow for some ambiguity in what the actual order will be if several services specify that they should come after the same step or service.  I'm not convinced that it would really matter what the order is.  Yes, if a given service needs to be processed after another then the order does matter but in that case the <after> tag should be changed to reflect that need.  If we have two custom services that both need to be started after HBASE then it shouldn't matter which one gets started before the other.  If there are dependencies between those two custom services then one should state it should be started after the other.


> On March 29, 2016, 12:49 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java, lines 535-547
> > <https://reviews.apache.org/r/45169/diff/1/?file=1310660#file1310660line535>
> >
> >     What exactly is the use case for marshalling back to the filesystem?  Filesystem access is read-only when running Ambari as non-root, so this code will not work.  If you are looking for merge-ordering or something to make an "uber upgrade pack", then that can be done at orchestration or keep it in-memory.
> 
> Tim Thorpe wrote:
>     Hi Nate, the purpose was really for testing.  I marshalled the results file back to the FS so I could compare the results with the original upgrade xml.

Forgot to mention, this code will be removed.


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------------------------------------------------------


On March 22, 2016, 6:40 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 6:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
>     https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> -------
> 
> Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.
> 
> This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>


Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On March 29, 2016, 12:49 p.m., Nate Cole wrote:
> > I think you need a more concrete way of ordering here.  What if two services are marked as <after> YARN?  Which one takes precedence?  You may want to introduce an <service name="FALCON" order="1.0" /> in order to specifically state how it happens.  Order would be a float, such that if we have a 1.0 and a 2.0, and some service goes in between, then we don't need to reorder the world (just use 1.5, or 1.1 or whatever).
> > 
> > In addition, if you are making separate files, it's conceivable that config changes for services can go directly in their respective files.  We broke them up to separate church-and-state, if you will.
> > 
> > It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.

RE: It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
+1 on allowing add-on/custom service to extend stack upgrade packs instead of breaking down the entire upgrade pack to service level.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------------------------------------------------------


On March 22, 2016, 6:40 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 6:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
>     https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> -------
> 
> Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.
> 
> This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>


Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

Posted by Tim Thorpe <tt...@ca.ibm.com>.

> On March 29, 2016, 12:49 p.m., Nate Cole wrote:
> > I think you need a more concrete way of ordering here.  What if two services are marked as <after> YARN?  Which one takes precedence?  You may want to introduce an <service name="FALCON" order="1.0" /> in order to specifically state how it happens.  Order would be a float, such that if we have a 1.0 and a 2.0, and some service goes in between, then we don't need to reorder the world (just use 1.5, or 1.1 or whatever).
> > 
> > In addition, if you are making separate files, it's conceivable that config changes for services can go directly in their respective files.  We broke them up to separate church-and-state, if you will.
> > 
> > It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
> 
> Jayush Luniya wrote:
>     RE: It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
>     +1 on allowing add-on/custom service to extend stack upgrade packs instead of breaking down the entire upgrade pack to service level.
> 
> Tim Thorpe wrote:
>     We decided we wouldn't split the upgrade xml into pieces for all the stack services.  Instead the goal will be limited to allow custom services to integrate into the upgrade process by providing their own service upgrade xml which will define their prereqs, order and process.  This means we still need a way for a service to indicate when during the process each of its steps needs to be done.
>     
>     I am a bit leary of the order number because there are actually two ways that service steps need to get added.  (In the example below I will still use core services to demonstrate).
>     
>     The first case is where a service needs to get integrated into an exists step.  In the example below, a service (HBASE) needs to be backed up prior to upgrade:
>     
>         <group xsi:type="cluster" name="PREPARE_BACKUPS" title="Prepare Backups">
>           <after>KNOX</after>
>           <execute-stage service="HBASE" component="HBASE_MASTER" title="Pre Upgrade HBase Backup">
>             <task xsi:type="execute" hosts="master">
>               <script>scripts/hbase_upgrade.py</script>
>               <function>take_snapshot</function>
>             </task>
>           </execute-stage>
>         </group>
>     
>     The second case is where a service has a new step which just needs to be included in the order.  In the example below, a service (KNOX) needs a new step added:
>     
>         <group name="KNOX" title="Knox">
>           <after>KAFKA</after>
>           <skippable>true</skippable>
>           <service name="KNOX">
>             <component>KNOX_GATEWAY</component>
>           </service>
>         </group>
>         
>     Nate proposed using an order number but this gets messy in the case of integrating into an existing step.  There would be 2 order numbers, one for the group and the other for the execute-stage:
>     
>         <group xsi:type="cluster" name="PREPARE_BACKUPS" title="Prepare Backups" order="2">
>           <execute-stage service="HBASE" component="HBASE_MASTER" title="Pre Upgrade HBase Backup" order="2.35">
>             <task xsi:type="execute" hosts="master">
>               <script>scripts/hbase_upgrade.py</script>
>               <function>take_snapshot</function>
>             </task>
>           </execute-stage>
>         </group>
>         
>     This seems a bit confusing.  It would also require changes to the actual upgrade xml when now we would otherwise not require any changes to those files.  Using a tag like <after>, does allow for some ambiguity in what the actual order will be if several services specify that they should come after the same step or service.  I'm not convinced that it would really matter what the order is.  Yes, if a given service needs to be processed after another then the order does matter but in that case the <after> tag should be changed to reflect that need.  If we have two custom services that both need to be started after HBASE then it shouldn't matter which one gets started before the other.  If there are dependencies between those two custom services then one should state it should be started after the other.
> 
> Nate Cole wrote:
>     You could use order only at the group level.  I wouldn't expect that you would be "injecting" execute-stage into an existing <group>/<execute-stage> as those are already-vetted actions.  There's no reason that two groups in a row can't work against the same service/component.  You're right that most cases the order doesn't matter, but the design should allow for it.

Hi Nate, There are several areas were order maybe needed: 

1) ordering check elements within the prerequisite-checks tag
2) ordering group elements within the order tag
3) ordering execute-stage elements within a particular group tag (such as within prepare backups)
4) ordering service elements within a particular group tag (such as within the core slaves section)
5) ordering service elements within a priority tag (for service checks)

I can see using an order attribute within the group elements but adding an order attribute to the execute-stage and service elements would get confusing.  If only custom services use the separate service specific upgrade xml, then adding all this information to the main upgrade xml just adds clutter and confusion.  If I am the developer of a custom service and my service depends on HIVE and requires a backup prior in the prepare backups step, then it is my responsibility to decide and declare where my service fits into the upgrade order.  I can declare that that the restart would come after HIVE which would place it between HIVE and SPARK or I could put it at the end of all the core restart which would place it after FLUME.  Since the restart is a group, specifying the order would be mandatory in a service specific upgrade file.  For the backup, specifying the order would be optional because it can always be placed at the end of the execute-stage list.

The only time the order will become "arbitrary" is when there are multiple custom services that all specify their own service specific upgrades.  If these services don't have interdependencies then there should be no need for the developers of those custom services to work together to determine a logical order.  In fact the developers may not be aware of the existence of these other custom services (or their upgrade requirements).  In that situation, regardless of whether an order attribute or an after tag is used, the services could specify the same ordering.  Such as custom service X and custom service Y both specify order=1.5 or both specify after HIVE.  If there are dependencies then the developer of the dependent service would need to look at the service specific upgrade of the service they depend upon to determine how they should order their component in the upgrade process.

In my mind, the benefit of the after tag is that it only needs to be specified at the service specific upgrade level and the overall upgrade xmls can remain the same.


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------------------------------------------------------


On March 22, 2016, 6:40 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 6:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
>     https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> -------
> 
> Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.
> 
> This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>


Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

Posted by Nate Cole <nc...@hortonworks.com>.

> On March 29, 2016, 8:49 a.m., Nate Cole wrote:
> > I think you need a more concrete way of ordering here.  What if two services are marked as <after> YARN?  Which one takes precedence?  You may want to introduce an <service name="FALCON" order="1.0" /> in order to specifically state how it happens.  Order would be a float, such that if we have a 1.0 and a 2.0, and some service goes in between, then we don't need to reorder the world (just use 1.5, or 1.1 or whatever).
> > 
> > In addition, if you are making separate files, it's conceivable that config changes for services can go directly in their respective files.  We broke them up to separate church-and-state, if you will.
> > 
> > It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
> 
> Jayush Luniya wrote:
>     RE: It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.
>     +1 on allowing add-on/custom service to extend stack upgrade packs instead of breaking down the entire upgrade pack to service level.
> 
> Tim Thorpe wrote:
>     We decided we wouldn't split the upgrade xml into pieces for all the stack services.  Instead the goal will be limited to allow custom services to integrate into the upgrade process by providing their own service upgrade xml which will define their prereqs, order and process.  This means we still need a way for a service to indicate when during the process each of its steps needs to be done.
>     
>     I am a bit leary of the order number because there are actually two ways that service steps need to get added.  (In the example below I will still use core services to demonstrate).
>     
>     The first case is where a service needs to get integrated into an exists step.  In the example below, a service (HBASE) needs to be backed up prior to upgrade:
>     
>         <group xsi:type="cluster" name="PREPARE_BACKUPS" title="Prepare Backups">
>           <after>KNOX</after>
>           <execute-stage service="HBASE" component="HBASE_MASTER" title="Pre Upgrade HBase Backup">
>             <task xsi:type="execute" hosts="master">
>               <script>scripts/hbase_upgrade.py</script>
>               <function>take_snapshot</function>
>             </task>
>           </execute-stage>
>         </group>
>     
>     The second case is where a service has a new step which just needs to be included in the order.  In the example below, a service (KNOX) needs a new step added:
>     
>         <group name="KNOX" title="Knox">
>           <after>KAFKA</after>
>           <skippable>true</skippable>
>           <service name="KNOX">
>             <component>KNOX_GATEWAY</component>
>           </service>
>         </group>
>         
>     Nate proposed using an order number but this gets messy in the case of integrating into an existing step.  There would be 2 order numbers, one for the group and the other for the execute-stage:
>     
>         <group xsi:type="cluster" name="PREPARE_BACKUPS" title="Prepare Backups" order="2">
>           <execute-stage service="HBASE" component="HBASE_MASTER" title="Pre Upgrade HBase Backup" order="2.35">
>             <task xsi:type="execute" hosts="master">
>               <script>scripts/hbase_upgrade.py</script>
>               <function>take_snapshot</function>
>             </task>
>           </execute-stage>
>         </group>
>         
>     This seems a bit confusing.  It would also require changes to the actual upgrade xml when now we would otherwise not require any changes to those files.  Using a tag like <after>, does allow for some ambiguity in what the actual order will be if several services specify that they should come after the same step or service.  I'm not convinced that it would really matter what the order is.  Yes, if a given service needs to be processed after another then the order does matter but in that case the <after> tag should be changed to reflect that need.  If we have two custom services that both need to be started after HBASE then it shouldn't matter which one gets started before the other.  If there are dependencies between those two custom services then one should state it should be started after the other.

You could use order only at the group level.  I wouldn't expect that you would be "injecting" execute-stage into an existing <group>/<execute-stage> as those are already-vetted actions.  There's no reason that two groups in a row can't work against the same service/component.  You're right that most cases the order doesn't matter, but the design should allow for it.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------------------------------------------------------


On March 22, 2016, 2:40 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 2:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
>     https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> -------
> 
> Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.
> 
> This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>


Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

Posted by Tim Thorpe <tt...@ca.ibm.com>.

> On March 29, 2016, 12:49 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java, lines 535-547
> > <https://reviews.apache.org/r/45169/diff/1/?file=1310660#file1310660line535>
> >
> >     What exactly is the use case for marshalling back to the filesystem?  Filesystem access is read-only when running Ambari as non-root, so this code will not work.  If you are looking for merge-ordering or something to make an "uber upgrade pack", then that can be done at orchestration or keep it in-memory.

Hi Nate, the purpose was really for testing.  I marshalled the results file back to the FS so I could compare the results with the original upgrade xml.


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------------------------------------------------------


On March 22, 2016, 6:40 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 6:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
>     https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> -------
> 
> Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.
> 
> This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>


Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------------------------------------------------------



I think you need a more concrete way of ordering here.  What if two services are marked as <after> YARN?  Which one takes precedence?  You may want to introduce an <service name="FALCON" order="1.0" /> in order to specifically state how it happens.  Order would be a float, such that if we have a 1.0 and a 2.0, and some service goes in between, then we don't need to reorder the world (just use 1.5, or 1.1 or whatever).

In addition, if you are making separate files, it's conceivable that config changes for services can go directly in their respective files.  We broke them up to separate church-and-state, if you will.

It seems like a more achievable goal might be to allow services to announce how they fit into how the upgrade packs work today, without rewriting how the whole system works.


ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java (lines 526 - 538)
<https://reviews.apache.org/r/45169/#comment188740>

    What exactly is the use case for marshalling back to the filesystem?  Filesystem access is read-only when running Ambari as non-root, so this code will not work.  If you are looking for merge-ordering or something to make an "uber upgrade pack", then that can be done at orchestration or keep it in-memory.



ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java (line 778)
<https://reviews.apache.org/r/45169/#comment188741>

    See above.  We can't marshal back to the OS.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java (line 156)
<https://reviews.apache.org/r/45169/#comment188742>

    Javadoc


- Nate Cole


On March 22, 2016, 2:40 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 2:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
>     https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the upgrade is defined as a series of xml files specific to the current stack version and the target stack version. Each upgrade xml defines the overall sequence of the upgrade and what needs to be done for each service. It would both easier to maintain and easier to add new services, if the services themselves could specify what should be done during their upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to only make the java changes and not split the upgrade xml files.  This would still allow new services to add themselves into the upgrade.  The benefit of this is that for the stack services you only have one upgrade xml file.  The problem with that is it is easier for a particular service to have unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java 9e2f997 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java c552e41 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 67d7fdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 430114b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 1b6cb8b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml f1d3c82 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d23c992 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 78bee7e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml b1599ea 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d826446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 74453e7 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ed30846 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 5fa0966 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> -------
> 
> Manual testing so far.  I have the code read the upgrade xml and all of its service specific xml files, built the upgrade pack and then write the full upgrade xml to disk and then compare the results to the original upgrade xml.
> 
> This review is mostly for the design doc which is attached to the JIRA.  Not sure how to create a review board with a design doc instead of a patch file.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>