You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/01 15:08:05 UTC
[GitHub] [spark] wankunde opened a new pull request, #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
wankunde opened a new pull request, #37759:
URL: https://github.com/apache/spark/pull/37759
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Support more than Integer.MAX_VALUE of the same join key.
### Why are the changes needed?
For SMJ, the number of the same join key records of the right table is greater than Integer.MAX_VALUE, the result will be incorrect.
Before SMJ JOIN, we will put the records of the same join key into the ExternalAppendOnlyUnsafeRowArray. ExternalAppendOnlyUnsafeRowArray.numRows overflow may cause OOM. During SMJ JOIN, SpillableArrayIterator.startIndex overflow may cause incorrect result.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wankunde commented on pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
wankunde commented on PR #37759:
URL: https://github.com/apache/spark/pull/37759#issuecomment-1238852769
> Can we add a test? or at least can you describe how you tested it?
A simple UT
```
test("join with too many duplicate key") {
withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
val duplicateKeyNumber = Integer.MAX_VALUE + 2
val df1 = Seq(1).toDF("id")
val df2 =
spark.range(1, duplicateKeyNumber, 1, 1000).map(_ => 1).toDF("id")
df1.join(df2, Seq("id"), "inner").collect()
}
}
```
For this SMJ, the SortMergeJoinScanner will append all `id=1` rows into a `ExternalAppendOnlyUnsafeRowArray`. After appending `Integer.MAX_VALUE` rows, `ExternalAppendOnlyUnsafeRowArray.numRows` will be overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37759:
URL: https://github.com/apache/spark/pull/37759#issuecomment-1259211420
@wankunde
in your UT, the variable `duplicateKeyNumber` is negative
```
scala> val duplicateKeyNumber = Integer.MAX_VALUE + 2
val duplicateKeyNumber: Int = -2147483647
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37759:
URL: https://github.com/apache/spark/pull/37759#discussion_r960788909
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala:
##########
@@ -76,15 +76,15 @@ private[sql] class ExternalAppendOnlyUnsafeRowArray(
private var spillableArray: UnsafeExternalSorter = _
private var totalSpillBytes: Long = 0
- private var numRows = 0
+ private var numRows = 0L
Review Comment:
`private var numRows` -> `private var numRows: Long =`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37759:
URL: https://github.com/apache/spark/pull/37759#issuecomment-1374972033
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wankunde commented on a diff in pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
wankunde commented on code in PR #37759:
URL: https://github.com/apache/spark/pull/37759#discussion_r961728679
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala:
##########
@@ -76,15 +76,15 @@ private[sql] class ExternalAppendOnlyUnsafeRowArray(
private var spillableArray: UnsafeExternalSorter = _
private var totalSpillBytes: Long = 0
- private var numRows = 0
+ private var numRows = 0L
Review Comment:
Fixed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37759:
URL: https://github.com/apache/spark/pull/37759#issuecomment-1235488346
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
URL: https://github.com/apache/spark/pull/37759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wankunde commented on pull request #37759: [SPARK-40306][SQL]Support more than Integer.MAX_VALUE of the same join key
Posted by GitBox <gi...@apache.org>.
wankunde commented on PR #37759:
URL: https://github.com/apache/spark/pull/37759#issuecomment-1263005199
@zhengruifeng I'm sorry, I made a mistake, it should be `val duplicateKeyNumber = 2L + Integer.MAX_VALUE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org