You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/11/12 17:08:07 UTC
Review Request 40234: Added descriptions of new Docker-related flags
to configuration documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/
-----------------------------------------------------------
Review request for mesos, Till Toenshoff and Timothy Chen.
Bugs: MESOS-3905
https://issues.apache.org/jira/browse/MESOS-3905
Repository: mesos
Description
-------
Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
add(&Flags::docker_auth_server,
"docker_auth_server",
"Docker authentication server",
"auth.docker.io");
add(&Flags::docker_auth_server_port,
"docker_auth_server_port",
"Docker authentication server port",
"443");
add(&Flags::docker_puller_timeout_secs,
"docker_puller_timeout",
"Timeout value in seconds for pulling images from Docker registry",
"60");
add(&Flags::docker_registry,
"docker_registry",
"Default Docker image registry server host",
"registry-1.docker.io");
add(&Flags::docker_registry_port,
"docker_registry_port",
"Default Docker registry server port",
"443");
Diffs
-----
docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
Diff: https://reviews.apache.org/r/40234/diff/
Testing
-------
Looked at configuration.md in a web browser and a markdown renderer.
Thanks,
Bernd Mathiske
Re: Review Request 40234: Added descriptions of new Docker-related
flags to configuration documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/#review106261
-----------------------------------------------------------
Seems we are missing a few though - a quick comparison of slave/flags.cpp with the doc reveals undescribed things like;
docker_local_archives_dir, docker_puller, docker_store_dir and maybe more? Can you please do a quick diff and add what's missing? Thanks!
- Till Toenshoff
On Nov. 12, 2015, 4:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40234/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 4:08 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Bugs: MESOS-3905
> https://issues.apache.org/jira/browse/MESOS-3905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
>
> add(&Flags::docker_auth_server,
> "docker_auth_server",
> "Docker authentication server",
> "auth.docker.io");
>
> add(&Flags::docker_auth_server_port,
> "docker_auth_server_port",
> "Docker authentication server port",
> "443");
> add(&Flags::docker_puller_timeout_secs,
> "docker_puller_timeout",
> "Timeout value in seconds for pulling images from Docker registry",
> "60");
>
> add(&Flags::docker_registry,
> "docker_registry",
> "Default Docker image registry server host",
> "registry-1.docker.io");
>
> add(&Flags::docker_registry_port,
> "docker_registry_port",
> "Default Docker registry server port",
> "443");
>
>
> Diffs
> -----
>
> docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
>
> Diff: https://reviews.apache.org/r/40234/diff/
>
>
> Testing
> -------
>
> Looked at configuration.md in a web browser and a markdown renderer.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 40234: Added descriptions of new Docker-related
flags to configuration documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/#review106262
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Nov. 12, 2015, 4:26 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40234/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 4:26 p.m.)
>
>
> Review request for mesos, Neil Conway, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3905
> https://issues.apache.org/jira/browse/MESOS-3905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
>
> add(&Flags::docker_auth_server,
> "docker_auth_server",
> "Docker authentication server",
> "auth.docker.io");
>
> add(&Flags::docker_auth_server_port,
> "docker_auth_server_port",
> "Docker authentication server port",
> "443");
> add(&Flags::docker_puller_timeout_secs,
> "docker_puller_timeout",
> "Timeout value in seconds for pulling images from Docker registry",
> "60");
>
> add(&Flags::docker_registry,
> "docker_registry",
> "Default Docker image registry server host",
> "registry-1.docker.io");
>
> add(&Flags::docker_registry_port,
> "docker_registry_port",
> "Default Docker registry server port",
> "443");
>
>
> Diffs
> -----
>
> docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
> src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
>
> Diff: https://reviews.apache.org/r/40234/diff/
>
>
> Testing
> -------
>
> Looked at configuration.md in a web browser and a markdown renderer.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 40234: Added descriptions of new Docker-related
flags to configuration documentation.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 8:26 a.m.)
Review request for mesos, Neil Conway, Till Toenshoff, and Timothy Chen.
Changes
-------
Added extra flags that were missing since before 0.25. Made Captilization consistent in flags.hpp.
Bugs: MESOS-3905
https://issues.apache.org/jira/browse/MESOS-3905
Repository: mesos
Description
-------
Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
add(&Flags::docker_auth_server,
"docker_auth_server",
"Docker authentication server",
"auth.docker.io");
add(&Flags::docker_auth_server_port,
"docker_auth_server_port",
"Docker authentication server port",
"443");
add(&Flags::docker_puller_timeout_secs,
"docker_puller_timeout",
"Timeout value in seconds for pulling images from Docker registry",
"60");
add(&Flags::docker_registry,
"docker_registry",
"Default Docker image registry server host",
"registry-1.docker.io");
add(&Flags::docker_registry_port,
"docker_registry_port",
"Default Docker registry server port",
"443");
Diffs (updated)
-----
docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
Diff: https://reviews.apache.org/r/40234/diff/
Testing
-------
Looked at configuration.md in a web browser and a markdown renderer.
Thanks,
Bernd Mathiske
Re: Review Request 40234: Added descriptions of new Docker-related
flags to configuration documentation.
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On Nov. 12, 2015, 8:13 a.m., Neil Conway wrote:
> > Also: AWESOME! Thank you for working on docs :)
Just working on the 0.26.0 release :-)
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/#review106258
-----------------------------------------------------------
On Nov. 12, 2015, 8:08 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40234/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 8:08 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Bugs: MESOS-3905
> https://issues.apache.org/jira/browse/MESOS-3905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
>
> add(&Flags::docker_auth_server,
> "docker_auth_server",
> "Docker authentication server",
> "auth.docker.io");
>
> add(&Flags::docker_auth_server_port,
> "docker_auth_server_port",
> "Docker authentication server port",
> "443");
> add(&Flags::docker_puller_timeout_secs,
> "docker_puller_timeout",
> "Timeout value in seconds for pulling images from Docker registry",
> "60");
>
> add(&Flags::docker_registry,
> "docker_registry",
> "Default Docker image registry server host",
> "registry-1.docker.io");
>
> add(&Flags::docker_registry_port,
> "docker_registry_port",
> "Default Docker registry server port",
> "443");
>
>
> Diffs
> -----
>
> docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
>
> Diff: https://reviews.apache.org/r/40234/diff/
>
>
> Testing
> -------
>
> Looked at configuration.md in a web browser and a markdown renderer.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 40234: Added descriptions of new Docker-related
flags to configuration documentation.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/#review106258
-----------------------------------------------------------
Also: AWESOME! Thank you for working on docs :)
- Neil Conway
On Nov. 12, 2015, 4:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40234/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 4:08 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Bugs: MESOS-3905
> https://issues.apache.org/jira/browse/MESOS-3905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
>
> add(&Flags::docker_auth_server,
> "docker_auth_server",
> "Docker authentication server",
> "auth.docker.io");
>
> add(&Flags::docker_auth_server_port,
> "docker_auth_server_port",
> "Docker authentication server port",
> "443");
> add(&Flags::docker_puller_timeout_secs,
> "docker_puller_timeout",
> "Timeout value in seconds for pulling images from Docker registry",
> "60");
>
> add(&Flags::docker_registry,
> "docker_registry",
> "Default Docker image registry server host",
> "registry-1.docker.io");
>
> add(&Flags::docker_registry_port,
> "docker_registry_port",
> "Default Docker registry server port",
> "443");
>
>
> Diffs
> -----
>
> docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
>
> Diff: https://reviews.apache.org/r/40234/diff/
>
>
> Testing
> -------
>
> Looked at configuration.md in a web browser and a markdown renderer.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 40234: Added descriptions of new Docker-related
flags to configuration documentation.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40234/#review106257
-----------------------------------------------------------
docs/configuration.md (line 1049)
<https://reviews.apache.org/r/40234/#comment165017>
I agree we should capitalize "Docker", but if we're going to do this, can we do it consistently, both here and in flags.cpp?
- Neil Conway
On Nov. 12, 2015, 4:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40234/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 4:08 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Bugs: MESOS-3905
> https://issues.apache.org/jira/browse/MESOS-3905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added descriptions of new Docker-related flags to configuration.md. See slave/flags.cpp:
>
> add(&Flags::docker_auth_server,
> "docker_auth_server",
> "Docker authentication server",
> "auth.docker.io");
>
> add(&Flags::docker_auth_server_port,
> "docker_auth_server_port",
> "Docker authentication server port",
> "443");
> add(&Flags::docker_puller_timeout_secs,
> "docker_puller_timeout",
> "Timeout value in seconds for pulling images from Docker registry",
> "60");
>
> add(&Flags::docker_registry,
> "docker_registry",
> "Default Docker image registry server host",
> "registry-1.docker.io");
>
> add(&Flags::docker_registry_port,
> "docker_registry_port",
> "Default Docker registry server port",
> "443");
>
>
> Diffs
> -----
>
> docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b
>
> Diff: https://reviews.apache.org/r/40234/diff/
>
>
> Testing
> -------
>
> Looked at configuration.md in a web browser and a markdown renderer.
>
>
> Thanks,
>
> Bernd Mathiske
>
>