You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zhangchao53 (via GitHub)" <gi...@apache.org> on 2023/08/10 14:40:00 UTC

[GitHub] [nuttx-apps] zhangchao53 opened a new pull request, #1945: Feat porting super pi

zhangchao53 opened a new pull request, #1945:
URL: https://github.com/apache/nuttx-apps/pull/1945

   ## Summary
   porting super pi
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] acassis commented on a diff in pull request #1945: Feat porting super pi

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #1945:
URL: https://github.com/apache/nuttx-apps/pull/1945#discussion_r1290586820


##########
testing/superpi/Kconfig:
##########
@@ -0,0 +1,37 @@
+
+#
+# Copyright (C) 2020 Xiaomi Corporation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#

Review Comment:
   Please remove, normally Kconfig doesn't have license and the license needs to follow the Apache template



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1945: Feat porting super pi

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1945:
URL: https://github.com/apache/nuttx-apps/pull/1945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] acassis commented on pull request #1945: Feat porting super pi

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #1945:
URL: https://github.com/apache/nuttx-apps/pull/1945#issuecomment-1673788598

   Please remove VELAPLATFO-11954 and squash the commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] acassis commented on a diff in pull request #1945: Feat porting super pi

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #1945:
URL: https://github.com/apache/nuttx-apps/pull/1945#discussion_r1290587134


##########
testing/superpi/Make.defs:
##########
@@ -0,0 +1,19 @@
+#
+# Copyright (C) 2020 Xiaomi Corporation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+

Review Comment:
   Ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org