You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org> on 2024/11/20 12:53:51 UTC
[PR] WIP-Cassgo 33 snappy has been moved to a separate package [cassandra-gocql-driver]
OleksiienkoMykyta opened a new pull request, #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on code in PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#discussion_r2013809502
##########
snappy/snappy-compressor.go:
##########
@@ -0,0 +1,28 @@
+package snappy
+
+import "github.com/golang/snappy"
Review Comment:
I tried to align it with lz4, but sure, we can keep it just as a `compressor.go`.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2758346493
Can you rebase this branch so it gets the changes from trunk? With this I think we will see the snappy unit tests run on CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on code in PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#discussion_r2013804612
##########
CHANGELOG.md:
##########
@@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Moved the Snappy compressor into its own separate package.
+ This allows users to include only the compression dependencies they need. (CASSGO-33)
Review Comment:
I agree, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2753892736
> Left 1 comment about the change in CHANGELOG.md and the new file name for the snappy compressor.
>
> I'm not sure if the tests under `snappy/compressor_test.go` will run. I believe this is being handled in #1864 but it would be nice to get confirmation that these tests are passing before merging this.
>
> Maybe we can wait for #1864 to be merged before merging this one.
Sure, let's wait for it. It's always better to double-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] WIP-Cassgo 33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2733719814
@OleksiienkoMykyta can you rebase this branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#discussion_r2054419043
##########
snappy/compressor_test.go:
##########
@@ -22,7 +22,7 @@
* See the NOTICE file distributed with this work for additional information.
*/
-package gocql
+package snappy
Review Comment:
This file is missing
```
//go:build all || unit
// +build all unit
```
so it runs in the CI unit tests step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2854906681
@OleksiienkoMykyta do you have time to address [this](https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2821807834)? We're trying to resolve the remaining pending PRs for the 2.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassgo 33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#discussion_r2012733327
##########
snappy/snappy-compressor.go:
##########
@@ -0,0 +1,28 @@
+package snappy
+
+import "github.com/golang/snappy"
Review Comment:
We can have this file be named `compressor.go` no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2821807834
integration tests with snappy appear fine so when you [add this](https://github.com/apache/cassandra-gocql-driver/pull/1844#discussion_r2054419043) I'll merge this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] WIP-Cassgo 33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#discussion_r2012728545
##########
CHANGELOG.md:
##########
@@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Moved the Snappy compressor into its own separate package.
+ This allows users to include only the compression dependencies they need. (CASSGO-33)
Review Comment:
I think we don't need this last line, it would be good to keep this list brief, users can open the linked JIRAs if they want more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] WIP-Cassgo 33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2742759126
> @OleksiienkoMykyta can you rebase this branch? Or even start from scratch (from trunk) and force push to this branch, might be easier
Sure, I'll handle this on the next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] WIP-Cassgo 33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844#issuecomment-2750812034
@joao-r-reis, I have fixed the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-33 snappy has been moved to a separate package [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis merged PR #1844:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org