[GitHub] incubator-quickstep pull request #198: patch to fix gcc compile error gflags

[cramja <gi...@git.apache.org>]

GitHub user cramja opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/198

    patch to fix gcc compile error gflags

    This fix adds a patch to the third party library `gflags` so that compilation will work with certain versions of GCC which were previously erroring on a warn->error for an unsigned to signed conversion.
    
    @jianqiao 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cramja/incubator-quickstep fix-compile-gcc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #198
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #198: patch to fix gcc compile error gflags

[jianqiao <gi...@git.apache.org>]

Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/198
  
    Great! Thanks Marc @cramja.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #198: patch to fix gcc compile error gflags

[cramja <gi...@git.apache.org>]

Github user cramja commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/198
  
    The patch fixes arguably bad style on the part of the 3rd party library authors, so I do not think there's reason to revert the patch. However, in the future it would be much easier to just change the compiler flags like you suggested. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #198: patch to fix gcc compile error gflags

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/198


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #198: patch to fix gcc compile error gflags

[zuyu <gi...@git.apache.org>]

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/198
  
    It is more about maintainability when we try to upgrade the third party while our patch may not work in a new release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #198: patch to fix gcc compile error gflags

[zuyu <gi...@git.apache.org>]

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/198
  
    @cramja If I remembered correctly, we disable some waring->error flags for building third party libraries. So for this issue, I suggest to disable certain cxx flags, instead of adding a patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---