You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2018/02/16 15:05:38 UTC

[GitHub] drill pull request #1123: DRILL-6154: NaN, Infinity issues

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1123#discussion_r168777666
  
    --- Diff: exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java ---
    @@ -102,7 +102,20 @@ public void add() {
     	  </#if>
         nonNullCount.value = 1;
     	  <#if aggrtype.funcName == "min">
    -	    value.value = Math.min(value.value, in.value);
    +			<#if type.inputType?contains("Float4") || type.inputType?contains("Float8")>
    --- End diff --
    
    1. Please mind original indent.
    2. Please add comment describing how we chose min / max for nan / inf values.
    3. Please consider using if without nested if: `if - elseif - else`.


---