You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/03/18 13:06:48 UTC

[PR] [MINOR] Remove unnecessary InternalPriorityQueue [flink]

beliefer opened a new pull request, #26315:
URL: https://github.com/apache/flink/pull/26315

   ## What is the purpose of the change
   
   This PR proposes to remove unnecessary `InternalPriorityQueue`.
   Since `KeyGroupedInternalPriorityQueue` already extends `InternalPriorityQueue`.
   
   
   ## Brief change log
   
   Remove unnecessary `InternalPriorityQueue`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Remove unnecessary InternalPriorityQueue [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #26315:
URL: https://github.com/apache/flink/pull/26315


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Remove unnecessary InternalPriorityQueue [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26315:
URL: https://github.com/apache/flink/pull/26315#issuecomment-2739019036

   > @beliefer I have approved this - nit: please could you change the title so it starts with [hotfix] in line with the dev process. Thanks
   
   Thank you for your reminder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Remove unnecessary InternalPriorityQueue [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26315:
URL: https://github.com/apache/flink/pull/26315#issuecomment-2739750175

   @1996fanrui @davidradl Thanks a lot !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Remove unnecessary InternalPriorityQueue [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26315:
URL: https://github.com/apache/flink/pull/26315#issuecomment-2733211995

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2a042805915d1d7f6e44bc276f6b2089eb96e8f6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2a042805915d1d7f6e44bc276f6b2089eb96e8f6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a042805915d1d7f6e44bc276f6b2089eb96e8f6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Remove unnecessary InternalPriorityQueue [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26315:
URL: https://github.com/apache/flink/pull/26315#issuecomment-2735145521

   ping @StefanRRichter @zentol cc @1996fanrui @davidradl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Remove unnecessary InternalPriorityQueue [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #26315:
URL: https://github.com/apache/flink/pull/26315#issuecomment-2737080857

   @beliefer I have approved this - nit: please could you change the title so it starts with [hotfix] in line with the dev process. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org