You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/17 08:26:30 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24516: Update flask-appbuilder authlib/oauth dependency
potiuk opened a new pull request, #24516:
URL: https://github.com/apache/airflow/pull/24516
The dependency we have for flask-appbuilder oauth authentication
(for github/google authentication) should follow the limits
that flask-appbuilder current version has. We added authlib there
but apparently FAB currently limits authlib to <= 1.0 - we should
follow fab rather than have our own dependency here.
This has been pointed out in
https://github.com/dpgaspar/Flask-AppBuilder/issues/1861
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24516: Update flask-appbuilder authlib/oauth dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24516:
URL: https://github.com/apache/airflow/pull/24516#issuecomment-1158631686
I am also going to update authlib to 1.0.0 (from 1.0.1) in our constraints and released images (I will use the new way of generating images :). so that users are unaffected - apparently 1.0.1 breaks authentication flow of FAB
Constraints rock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24516: Update flask-appbuilder authlib/oauth dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24516:
URL: https://github.com/apache/airflow/pull/24516#issuecomment-1159787748
This one will also be needed when we merge #24399, so that we keep authlib synced with FAB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24516: Update flask-appbuilder authlib/oauth dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24516:
URL: https://github.com/apache/airflow/pull/24516#issuecomment-1159792095
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24516: Update flask-appbuilder authlib/oauth dependency
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24516:
URL: https://github.com/apache/airflow/pull/24516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org