You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/03 10:05:41 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #28109:
[SPARK-31253][SQL][followup] Add metric to the split task number for skew
optimization
cloud-fan commented on a change in pull request #28109: [SPARK-31253][SQL][followup] Add metric to the split task number for skew optimization
URL: https://github.com/apache/spark/pull/28109#discussion_r402898455
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -116,12 +117,24 @@ case class CustomShuffleReaderExec private(
}
private def skewedPartitionMetrics = {
- val metrics = SQLMetrics.createMetric(sparkContext, "number of skewed partitions")
- val numSkewedPartitions = partitionSpecs.collect {
- case p: PartialReducerPartitionSpec => p.reducerIndex
- }.distinct.length
- metrics.set(numSkewedPartitions)
- Map("numSkewedPartitions" -> metrics)
+ val skewedPartitions = SQLMetrics.createMetric(sparkContext, "number of skewed partitions")
+ val splitTasks = SQLMetrics.createMetric(sparkContext, "number of split tasks")
Review comment:
how about `number of skewed partition splits`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org