You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/07 14:45:04 UTC
[GitHub] zeppelin pull request #2108: [ZEPPELIN-2202] Disable personalized mode btn w...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2108
[ZEPPELIN-2202] Disable personalized mode btn when note is running (master)
### What is this PR for?
Disable the personalized mode button when a note is running.
- This improvement is implemented in https://github.com/1ambda/zeppelin/commit/0afacbf45e9d4e96121b662da87d4b7e3c655838.
- The second commit https://github.com/1ambda/zeppelin/commit/305ad05790c09920539f3e5b4e4763d04ccabfab is about refactoring.
- So please review https://github.com/1ambda/zeppelin/commit/0afacbf45e9d4e96121b662da87d4b7e3c655838 first.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2202](https://issues.apache.org/jira/browse/ZEPPELIN-2202)
### How should this be tested?
Refer the screenshot below.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2202/disable-person-mode-btn-when-note-is-running
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2108
----
commit 0afacbf45e9d4e96121b662da87d4b7e3c655838
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-07T13:47:54Z
feat: Disable person mode toggle btn when para is running
commit 305ad05790c09920539f3e5b4e4763d04ccabfab
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-07T14:32:49Z
refactor: Add ParagraphStatus const
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2108: [ZEPPELIN-2202] Disable personalized mode btn when not...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2108
@jongyoul Can you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2108: [ZEPPELIN-2202] Disable personalized mode btn when not...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2108
I'v just updated code. @Leemoonsoo Could you review again? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2108: [ZEPPELIN-2202] Disable personalized mode btn w...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2108
[ZEPPELIN-2202] Disable personalized mode btn when note is running (master)
### What is this PR for?
Disable the personalized mode button when a note is running.
- This improvement is done in https://github.com/1ambda/zeppelin/commit/0afacbf45e9d4e96121b662da87d4b7e3c655838.
- The second commit https://github.com/1ambda/zeppelin/commit/305ad05790c09920539f3e5b4e4763d04ccabfab is about refactoring.
- So please review https://github.com/1ambda/zeppelin/commit/0afacbf45e9d4e96121b662da87d4b7e3c655838 first.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2202](https://issues.apache.org/jira/browse/ZEPPELIN-2202)
### How should this be tested?
Refer the screenshot below.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2202/disable-person-mode-btn-when-note-is-running
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2108
----
commit 0afacbf45e9d4e96121b662da87d4b7e3c655838
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-07T13:47:54Z
feat: Disable person mode toggle btn when para is running
commit 305ad05790c09920539f3e5b4e4763d04ccabfab
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-07T14:32:49Z
refactor: Add ParagraphStatus const
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2108: [ZEPPELIN-2202] Disable personalized mode btn when not...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2108
Tested. LGTM. Merging if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2108: [ZEPPELIN-2202] Disable personalized mode btn when not...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2108
This is the same fix for branch-0.7
- https://github.com/apache/zeppelin/pull/2115/files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2108: [ZEPPELIN-2202] Disable personalized mode btn w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2108: [ZEPPELIN-2202] Disable personalized mode btn w...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---