[GitHub] [arrow] jorisvandenbossche commented on pull request #12657: ARROW-14821: [C++][R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on PR #12657:
URL: https://github.com/apache/arrow/pull/12657#issuecomment-1119580484

   > I suppose we can either document behaviour or let user choose the "origin unit". I would prefer to just document for now.
   
   Ah, letting the user choose could actually also be interesting: it leaves the custom logic to determine what the "greater unit" is to the R lubridate bindings, and it actually gives some flexibility to the user of the actual kernel (for example, you could want to round to a multiple of weeks since the start of the month or since the start of the year)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org