[jira] [Commented] (FLINK-10400) Return failed JobResult if job terminates in state FAILED or CANCELED

["tison (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625030#comment-16625030 ] 

tison commented on FLINK-10400:
-------------------------------

Agree. It is a code wart that should be fixed.
To be more clear, return a {{JobResult}} with {{Exception}} as described, {{addSuppressed}} if there is a failure cause.

> Return failed JobResult if job terminates in state FAILED or CANCELED
> ---------------------------------------------------------------------
>
>                 Key: FLINK-10400
>                 URL: https://issues.apache.org/jira/browse/FLINK-10400
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.6.1, 1.7.0, 1.5.4
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> If the job reaches the globally terminal state {{FAILED}} or {{CANCELED}}, the {{JobResult}} must return a non-successful result. At the moment, it can happen that in the {{CANCELED}} state where we don't find a failure cause that we return a successful {{JobResult}}.
> In order to change this I propose to always return a {{JobResult}} with a {{JobCancellationException}} in case of {{CANCELED}} and a {{JobExecutionException}} in case of {{FAILED}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)