You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/03/06 06:46:33 UTC

[jira] Created: (HARMONY-170) java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception

java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception
--------------------------------------------------------------------------------------

         Key: HARMONY-170
         URL: http://issues.apache.org/jira/browse/HARMONY-170
     Project: Harmony
        Type: Bug
  Components: Classlib  
    Reporter: Richard Liang


public final CoderResult encode(CharBuffer in, ByteBuffer out, boolean endOfInput)
As spec says, the method throws CoderMalfunctionError if an invocation of the decodeLoop method threw an unexpected exception.

However, Harmony doesn't throws CoderMalfunctionError when decodeLoop method threw an unexpected exception.

The attached test cases pass on RI , but fail on Harmony. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-170) java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-170?page=all ]

Tim Ellison reassigned HARMONY-170:
-----------------------------------

    Assign To: Tim Ellison

> java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception
> --------------------------------------------------------------------------------------
>
>          Key: HARMONY-170
>          URL: http://issues.apache.org/jira/browse/HARMONY-170
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Tim Ellison
>  Attachments: CharsetEncoderTest_patch.txt, CharsetEncoder_patch.txt
>
> public final CoderResult encode(CharBuffer in, ByteBuffer out, boolean endOfInput)
> As spec says, the method throws CoderMalfunctionError if an invocation of the decodeLoop method threw an unexpected exception.
> However, Harmony doesn't throws CoderMalfunctionError when decodeLoop method threw an unexpected exception.
> The attached test cases pass on RI , but fail on Harmony. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-170) java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-170?page=all ]

Richard Liang updated HARMONY-170:
----------------------------------

    Attachment: CharsetEncoder_patch.txt
                CharsetEncoderTest_patch.txt

Hello Tim,

Please try my patch and the proposed test cases. Thanks a lot.

> java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception
> --------------------------------------------------------------------------------------
>
>          Key: HARMONY-170
>          URL: http://issues.apache.org/jira/browse/HARMONY-170
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Richard Liang
>  Attachments: CharsetEncoderTest_patch.txt, CharsetEncoder_patch.txt
>
> public final CoderResult encode(CharBuffer in, ByteBuffer out, boolean endOfInput)
> As spec says, the method throws CoderMalfunctionError if an invocation of the decodeLoop method threw an unexpected exception.
> However, Harmony doesn't throws CoderMalfunctionError when decodeLoop method threw an unexpected exception.
> The attached test cases pass on RI , but fail on Harmony. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-170) java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-170?page=all ]
     
Tim Ellison resolved HARMONY-170:
---------------------------------

    Resolution: Fixed

Thanks Richard,

That was as exemplary JIRA report -- a patch for the code and test suite, and following the conventions!  It made the task of checking and applying the patch very easy, thank you!

Applied to NIO_CHAR module java.nio.charset.CharsetEncoder at repo revision 383871
.
Please check that the patch was applied as you expected.


> java.nio.charset.CharsetEncoder.encode method does not handle the unexpected exception
> --------------------------------------------------------------------------------------
>
>          Key: HARMONY-170
>          URL: http://issues.apache.org/jira/browse/HARMONY-170
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Tim Ellison
>  Attachments: CharsetEncoderTest_patch.txt, CharsetEncoder_patch.txt
>
> public final CoderResult encode(CharBuffer in, ByteBuffer out, boolean endOfInput)
> As spec says, the method throws CoderMalfunctionError if an invocation of the decodeLoop method threw an unexpected exception.
> However, Harmony doesn't throws CoderMalfunctionError when decodeLoop method threw an unexpected exception.
> The attached test cases pass on RI , but fail on Harmony. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira