You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by dw...@apache.org on 2007/05/01 23:13:29 UTC
svn commit: r534247 -
/geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
Author: dwoods
Date: Tue May 1 14:13:28 2007
New Revision: 534247
URL: http://svn.apache.org/viewvc?view=rev&rev=534247
Log:
GERONIMO-3128 Error in Geronimo.bat blocks its usage for Minimal assemblies, due to no bin\jpa.jar. Moved the usage of the quotes to where its set - JAVA_AGENT_OPTS=-javaagent:%JAVA_AGENT_JAR%. Also added the missing -Djava.ext.dirs to the :doJDB server startup section.
Modified:
geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat?view=diff&rev=534247&r1=534246&r2=534247
==============================================================================
--- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat (original)
+++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat Tue May 1 14:13:28 2007
@@ -314,15 +314,15 @@
@REM Setup the Java programming language agent
set JAVA_AGENT_JAR=%GERONIMO_BASE%\bin\jpa.jar
set JAVA_AGENT_OPTS=
-if exist "%JAVA_AGENT_JAR%" set JAVA_AGENT_OPTS=-javaagent:%JAVA_AGENT_JAR%
+if exist "%JAVA_AGENT_JAR%" set JAVA_AGENT_OPTS=-javaagent:"%JAVA_AGENT_JAR%"
@REM Execute Java with the applicable properties
if not "%JDB%" == "" goto doJDB
-%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% "%JAVA_AGENT_OPTS%" -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT% %CMD_LINE_ARGS%
+%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS% -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT% %CMD_LINE_ARGS%
goto end
:doJDB
-%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH%" -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS% %CMD_LINE_ARGS%
+%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH%" -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS% %CMD_LINE_ARGS%
goto end
:end
Re: svn commit: r534247 - /geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
Posted by Donald Woods <dw...@apache.org>.
Yep, I hear you.... and now that we are going to allow multiple server instances,
its going to get worse, since there is only one copy of the /bin files to be used
for all instances....
-Donald
Jason Dillon wrote:
> I figgen hate batch... why on earth doesn't microsoft just ship a bash
> shell and stop this insanity of crazy quotes and whack syntax.
> seriously hasn't anyone from microsoft considered it yet?
>
> * * *
>
> Our scripts are *way* too complicated... I really think its time we
> start thinking about adding a tiny bootstrap jvm to handle all of these
> complicated ext/endorsed, jpa, flags, etc, muck in Java, then spawn the
> *real* server jvm.
>
> --jason
>
>
> On May 1, 2007, at 2:13 PM, dwoods@apache.org wrote:
>
>> Author: dwoods
>> Date: Tue May 1 14:13:28 2007
>> New Revision: 534247
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=534247
>> Log:
>> GERONIMO-3128 Error in Geronimo.bat blocks its usage for Minimal
>> assemblies, due to no bin\jpa.jar. Moved the usage of the quotes to
>> where its set - JAVA_AGENT_OPTS=-javaagent:%JAVA_AGENT_JAR%. Also
>> added the missing -Djava.ext.dirs to the :doJDB server startup section.
>>
>> Modified:
>>
>> geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
>>
>>
>> Modified:
>> geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat?view=diff&rev=534247&r1=534246&r2=534247
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
>> (original)
>> +++
>> geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
>> Tue May 1 14:13:28 2007
>> @@ -314,15 +314,15 @@
>> @REM Setup the Java programming language agent
>> set JAVA_AGENT_JAR=%GERONIMO_BASE%\bin\jpa.jar
>> set JAVA_AGENT_OPTS=
>> -if exist "%JAVA_AGENT_JAR%" set
>> JAVA_AGENT_OPTS=-javaagent:%JAVA_AGENT_JAR%
>> +if exist "%JAVA_AGENT_JAR%" set
>> JAVA_AGENT_OPTS=-javaagent:"%JAVA_AGENT_JAR%"
>>
>> @REM Execute Java with the applicable properties
>> if not "%JDB%" == "" goto doJDB
>> -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% "%JAVA_AGENT_OPTS%"
>> -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext"
>> -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed"
>> -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%"
>> -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT%
>> %CMD_LINE_ARGS%
>> +%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS%
>> -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext"
>> -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed"
>> -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%"
>> -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT%
>> %CMD_LINE_ARGS%
>> goto end
>>
>> :doJDB
>> -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH%"
>> -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed"
>> -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%"
>> -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS%
>> %CMD_LINE_ARGS%
>> +%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH%"
>> -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext"
>> -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib\endorsed"
>> -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%"
>> -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS%
>> %CMD_LINE_ARGS%
>> goto end
>>
>> :end
>>
>>
>
>
>
Re: svn commit: r534247 - /geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
Posted by Jason Dillon <ja...@planet57.com>.
I figgen hate batch... why on earth doesn't microsoft just ship a
bash shell and stop this insanity of crazy quotes and whack syntax.
seriously hasn't anyone from microsoft considered it yet?
* * *
Our scripts are *way* too complicated... I really think its time we
start thinking about adding a tiny bootstrap jvm to handle all of
these complicated ext/endorsed, jpa, flags, etc, muck in Java, then
spawn the *real* server jvm.
--jason
On May 1, 2007, at 2:13 PM, dwoods@apache.org wrote:
> Author: dwoods
> Date: Tue May 1 14:13:28 2007
> New Revision: 534247
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=534247
> Log:
> GERONIMO-3128 Error in Geronimo.bat blocks its usage for Minimal
> assemblies, due to no bin\jpa.jar. Moved the usage of the quotes
> to where its set - JAVA_AGENT_OPTS=-javaagent:%JAVA_AGENT_JAR%.
> Also added the missing -Djava.ext.dirs to the :doJDB server startup
> section.
>
> Modified:
> geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/
> src/main/resources/bin/geronimo.bat
>
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate-
> minimal/src/main/resources/bin/geronimo.bat
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/
> geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat?
> view=diff&rev=534247&r1=534246&r2=534247
> ======================================================================
> ========
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/
> src/main/resources/bin/geronimo.bat (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/
> src/main/resources/bin/geronimo.bat Tue May 1 14:13:28 2007
> @@ -314,15 +314,15 @@
> @REM Setup the Java programming language agent
> set JAVA_AGENT_JAR=%GERONIMO_BASE%\bin\jpa.jar
> set JAVA_AGENT_OPTS=
> -if exist "%JAVA_AGENT_JAR%" set JAVA_AGENT_OPTS=-javaagent:%
> JAVA_AGENT_JAR%
> +if exist "%JAVA_AGENT_JAR%" set JAVA_AGENT_OPTS=-javaagent:"%
> JAVA_AGENT_JAR%"
>
> @REM Execute Java with the applicable properties
> if not "%JDB%" == "" goto doJDB
> -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% "%JAVA_AGENT_OPTS%" -
> Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -
> Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT% %
> CMD_LINE_ARGS%
> +%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS% -
> Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -
> Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT% %
> CMD_LINE_ARGS%
> goto end
>
> :doJDB
> -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH
> %" -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS
> % %CMD_LINE_ARGS%
> +%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH
> %" -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -
> Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS
> % %CMD_LINE_ARGS%
> goto end
>
> :end
>
>
Re: svn commit: r534247 - /geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat
Posted by Jason Dillon <ja...@planet57.com>.
I figgen hate batch... why on earth doesn't microsoft just ship a
bash shell and stop this insanity of crazy quotes and whack syntax.
seriously hasn't anyone from microsoft considered it yet?
* * *
Our scripts are *way* too complicated... I really think its time we
start thinking about adding a tiny bootstrap jvm to handle all of
these complicated ext/endorsed, jpa, flags, etc, muck in Java, then
spawn the *real* server jvm.
--jason
On May 1, 2007, at 2:13 PM, dwoods@apache.org wrote:
> Author: dwoods
> Date: Tue May 1 14:13:28 2007
> New Revision: 534247
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=534247
> Log:
> GERONIMO-3128 Error in Geronimo.bat blocks its usage for Minimal
> assemblies, due to no bin\jpa.jar. Moved the usage of the quotes
> to where its set - JAVA_AGENT_OPTS=-javaagent:%JAVA_AGENT_JAR%.
> Also added the missing -Djava.ext.dirs to the :doJDB server startup
> section.
>
> Modified:
> geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/
> src/main/resources/bin/geronimo.bat
>
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate-
> minimal/src/main/resources/bin/geronimo.bat
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/
> geronimo-boilerplate-minimal/src/main/resources/bin/geronimo.bat?
> view=diff&rev=534247&r1=534246&r2=534247
> ======================================================================
> ========
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/
> src/main/resources/bin/geronimo.bat (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/
> src/main/resources/bin/geronimo.bat Tue May 1 14:13:28 2007
> @@ -314,15 +314,15 @@
> @REM Setup the Java programming language agent
> set JAVA_AGENT_JAR=%GERONIMO_BASE%\bin\jpa.jar
> set JAVA_AGENT_OPTS=
> -if exist "%JAVA_AGENT_JAR%" set JAVA_AGENT_OPTS=-javaagent:%
> JAVA_AGENT_JAR%
> +if exist "%JAVA_AGENT_JAR%" set JAVA_AGENT_OPTS=-javaagent:"%
> JAVA_AGENT_JAR%"
>
> @REM Execute Java with the applicable properties
> if not "%JDB%" == "" goto doJDB
> -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% "%JAVA_AGENT_OPTS%" -
> Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -
> Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT% %
> CMD_LINE_ARGS%
> +%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS% -
> Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -
> Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -jar %_JARFILE% %_LONG_OPT% %
> CMD_LINE_ARGS%
> goto end
>
> :doJDB
> -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH
> %" -Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS
> % %CMD_LINE_ARGS%
> +%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% -sourcepath "%JDB_SRCPATH
> %" -Djava.ext.dirs="%GERONIMO_BASE%\lib\ext;%JRE_HOME%\lib\ext" -
> Djava.endorsed.dirs="%GERONIMO_BASE%\lib\endorsed;%JRE_HOME%\lib
> \endorsed" -Dorg.apache.geronimo.base.dir="%GERONIMO_BASE%" -
> Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath %_JARFILE% %MAINCLASS
> % %CMD_LINE_ARGS%
> goto end
>
> :end
>
>