You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2025/08/19 07:37:15 UTC
[PR] Disable start_from_trigger altogether for now [airflow]
uranusjr opened a new pull request, #54646:
URL: https://github.com/apache/airflow/pull/54646
Close #54627. See in-code comments for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #54646:
URL: https://github.com/apache/airflow/pull/54646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #54646:
URL: https://github.com/apache/airflow/pull/54646#discussion_r2286758567
##########
airflow-core/tests/unit/models/test_dagrun.py:
##########
@@ -2036,6 +2036,7 @@ def test_schedule_tis_map_index(dag_maker, session):
assert ti2.state == TaskInstanceState.SUCCESS
+@pytest.mark.xfail(reason="We can't keep this bevaviour with remote workers where scheduler can't reach xcom")
Review Comment:
Good catch, this is actually copied from another test so I’ll fix that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54646:
URL: https://github.com/apache/airflow/pull/54646#issuecomment-3203945299
### Backport failed to create: v3-0-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/17086824284'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-0-test</td>
<td><a href="https://github.com/apache/airflow/commit/91e10295c7d7bb293f7853a518579d619ceae74d"><img src='https://img.shields.io/badge/Commit-91e1029-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 91e1029 v3-0-test
```
This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #54646:
URL: https://github.com/apache/airflow/pull/54646#issuecomment-3200088171
What do we have to do to re-enable it for 3.1 timeframe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #54646:
URL: https://github.com/apache/airflow/pull/54646#discussion_r2284745379
##########
airflow-core/tests/unit/models/test_dagrun.py:
##########
@@ -2036,6 +2036,7 @@ def test_schedule_tis_map_index(dag_maker, session):
assert ti2.state == TaskInstanceState.SUCCESS
+@pytest.mark.xfail(reason="We can't keep this bevaviour with remote workers where scheduler can't reach xcom")
Review Comment:
```suggestion
@pytest.mark.xfail(reason="We can't keep this behaviour with remote workers where scheduler can't reach xcom")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #54646:
URL: https://github.com/apache/airflow/pull/54646#issuecomment-3204408506
Not going to backport per suggestion from @vatsrahul1001. This issue is not repro-able in 3.0.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #54646:
URL: https://github.com/apache/airflow/pull/54646#issuecomment-3203786823
We need to figure out how to render the task template without spawning a worker (or at least be able to spawn a process that’s significantly more lightweight than a task worker) to make this worthwhile. Otherwise I feel we should just remove this feature altogether since it would not provide any benefits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable start_from_trigger altogether for now [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #54646:
URL: https://github.com/apache/airflow/pull/54646#issuecomment-3206092197
> We need to figure out how to render the task template without spawning a worker (or at least be able to spawn a process that’s significantly more lightweight than a task worker) to make this worthwhile. Otherwise I feel we should just remove this feature altogether since it would not provide any benefits.
I have a PR open for that, it's a pity this has been closed as my [PR ](https://github.com/apache/airflow/pull/53071/) is ready to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org