You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Josh Rosen (Jira)" <ji...@apache.org> on 2022/07/02 00:19:00 UTC

[jira] [Created] (SPARK-39658) Reconsider exposure of Json4s symbols in public ResourceInformation.toJson API

Josh Rosen created SPARK-39658:
----------------------------------

             Summary: Reconsider exposure of Json4s symbols in public ResourceInformation.toJson API
                 Key: SPARK-39658
                 URL: https://issues.apache.org/jira/browse/SPARK-39658
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 3.0.0
            Reporter: Josh Rosen


Followup to discussion at [https://github.com/apache/spark/pull/36885#discussion_r898644147]

Spark's `ResourceInformation` class exposes Json4s symbols in its public API (via the toJson method). 

In the long run, I don't think that exposing third-party library symbols in our public APIs is a good idea. Perhaps we should make this API private or change it to require that users / implementors return an object which can be turned to JSON via Jackson ObjectMapper.

In principle we still have some freedom to change this because the ResourceInformation class is marked as `@Evolving`

I'm filing this ticket so that I can reference it in TODO code comments.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org