You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/01/28 04:32:43 UTC

[jira] Created: (CODEC-115) DoubleMetaphone.maxCodeLen should probably be private

DoubleMetaphone.maxCodeLen should probably be private
-----------------------------------------------------

                 Key: CODEC-115
                 URL: https://issues.apache.org/jira/browse/CODEC-115
             Project: Commons Codec
          Issue Type: Bug
    Affects Versions: 1.4
            Reporter: Sebb
            Priority: Minor


DoubleMetaphone.maxCodeLen should probably be private - it has public getter and setter anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CODEC-115) DoubleMetaphone.maxCodeLen should probably be private

Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CODEC-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory resolved CODEC-115.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5
         Assignee: Gary Gregory

> DoubleMetaphone.maxCodeLen should probably be private
> -----------------------------------------------------
>
>                 Key: CODEC-115
>                 URL: https://issues.apache.org/jira/browse/CODEC-115
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Sebb
>            Assignee: Gary Gregory
>            Priority: Minor
>             Fix For: 1.5
>
>
> DoubleMetaphone.maxCodeLen should probably be private - it has public getter and setter anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CODEC-115) DoubleMetaphone.maxCodeLen should probably be private

Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CODEC-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987931#action_12987931 ] 

Gary Gregory commented on CODEC-115:
------------------------------------

All ivars should be private or protected IMO. 

> DoubleMetaphone.maxCodeLen should probably be private
> -----------------------------------------------------
>
>                 Key: CODEC-115
>                 URL: https://issues.apache.org/jira/browse/CODEC-115
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Sebb
>            Priority: Minor
>
> DoubleMetaphone.maxCodeLen should probably be private - it has public getter and setter anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.