You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sa...@apache.org on 2017/08/05 14:59:42 UTC

[1/3] lucene-solr:master: SOLR-10796: TestPointFields.testDoublePointFieldRangeFacet(): Guard against converting a double-valued '-Infinity' to BigDecimal

Repository: lucene-solr
Updated Branches:
  refs/heads/branch_7_0 c58bbaa6c -> ec99019b3
  refs/heads/branch_7x 5d632c0a0 -> 23541b75c
  refs/heads/master 3f9e74820 -> cff5e9858


SOLR-10796: TestPointFields.testDoublePointFieldRangeFacet(): Guard against converting a double-valued '-Infinity' to BigDecimal


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/cff5e985
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/cff5e985
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/cff5e985

Branch: refs/heads/master
Commit: cff5e985835759b4fcb64629ddca817fa6e17944
Parents: 3f9e748
Author: Steve Rowe <sa...@apache.org>
Authored: Sat Aug 5 10:59:11 2017 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Sat Aug 5 10:59:11 2017 -0400

----------------------------------------------------------------------
 solr/core/src/test/org/apache/solr/schema/TestPointFields.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cff5e985/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/schema/TestPointFields.java b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
index 8192406..5a89e78 100644
--- a/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
+++ b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
@@ -615,7 +615,7 @@ public class TestPointFields extends SolrTestCaseJ4 {
       max = sortedValues.get(sortedValues.size() - 1);
       buffer = BigDecimal.valueOf(max).subtract(BigDecimal.valueOf(min))
           .divide(BigDecimal.valueOf(numValues / 2), RoundingMode.HALF_UP).doubleValue();
-      gap = BigDecimal.valueOf(max + buffer).subtract(BigDecimal.valueOf(min - buffer))
+      gap = BigDecimal.valueOf(max).subtract(BigDecimal.valueOf(min)).add(BigDecimal.valueOf(buffer * 2.0D))
           .divide(BigDecimal.valueOf(numBuckets), RoundingMode.HALF_UP).doubleValue();
     } while (max >= Double.MAX_VALUE - buffer || min <= -Double.MAX_VALUE + buffer);
     // System.err.println("min: " + min + "   max: " + max + "   gap: " + gap + "   buffer: " + buffer);

[3/3] lucene-solr:branch_7_0: SOLR-10796: TestPointFields.testDoublePointFieldRangeFacet(): Guard against converting a double-valued '-Infinity' to BigDecimal

Posted by sa...@apache.org.
SOLR-10796: TestPointFields.testDoublePointFieldRangeFacet(): Guard against converting a double-valued '-Infinity' to BigDecimal


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/ec99019b
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/ec99019b
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/ec99019b

Branch: refs/heads/branch_7_0
Commit: ec99019b3660cacdb10bb8f81923ad4111f99d7e
Parents: c58bbaa
Author: Steve Rowe <sa...@apache.org>
Authored: Sat Aug 5 10:59:11 2017 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Sat Aug 5 10:59:32 2017 -0400

----------------------------------------------------------------------
 solr/core/src/test/org/apache/solr/schema/TestPointFields.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/ec99019b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/schema/TestPointFields.java b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
index 8192406..5a89e78 100644
--- a/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
+++ b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
@@ -615,7 +615,7 @@ public class TestPointFields extends SolrTestCaseJ4 {
       max = sortedValues.get(sortedValues.size() - 1);
       buffer = BigDecimal.valueOf(max).subtract(BigDecimal.valueOf(min))
           .divide(BigDecimal.valueOf(numValues / 2), RoundingMode.HALF_UP).doubleValue();
-      gap = BigDecimal.valueOf(max + buffer).subtract(BigDecimal.valueOf(min - buffer))
+      gap = BigDecimal.valueOf(max).subtract(BigDecimal.valueOf(min)).add(BigDecimal.valueOf(buffer * 2.0D))
           .divide(BigDecimal.valueOf(numBuckets), RoundingMode.HALF_UP).doubleValue();
     } while (max >= Double.MAX_VALUE - buffer || min <= -Double.MAX_VALUE + buffer);
     // System.err.println("min: " + min + "   max: " + max + "   gap: " + gap + "   buffer: " + buffer);

[2/3] lucene-solr:branch_7x: SOLR-10796: TestPointFields.testDoublePointFieldRangeFacet(): Guard against converting a double-valued '-Infinity' to BigDecimal

Posted by sa...@apache.org.
SOLR-10796: TestPointFields.testDoublePointFieldRangeFacet(): Guard against converting a double-valued '-Infinity' to BigDecimal


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/23541b75
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/23541b75
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/23541b75

Branch: refs/heads/branch_7x
Commit: 23541b75c1a2452a94c1e26be76cc295470e4462
Parents: 5d632c0
Author: Steve Rowe <sa...@apache.org>
Authored: Sat Aug 5 10:59:11 2017 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Sat Aug 5 10:59:24 2017 -0400

----------------------------------------------------------------------
 solr/core/src/test/org/apache/solr/schema/TestPointFields.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/23541b75/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/schema/TestPointFields.java b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
index 8192406..5a89e78 100644
--- a/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
+++ b/solr/core/src/test/org/apache/solr/schema/TestPointFields.java
@@ -615,7 +615,7 @@ public class TestPointFields extends SolrTestCaseJ4 {
       max = sortedValues.get(sortedValues.size() - 1);
       buffer = BigDecimal.valueOf(max).subtract(BigDecimal.valueOf(min))
           .divide(BigDecimal.valueOf(numValues / 2), RoundingMode.HALF_UP).doubleValue();
-      gap = BigDecimal.valueOf(max + buffer).subtract(BigDecimal.valueOf(min - buffer))
+      gap = BigDecimal.valueOf(max).subtract(BigDecimal.valueOf(min)).add(BigDecimal.valueOf(buffer * 2.0D))
           .divide(BigDecimal.valueOf(numBuckets), RoundingMode.HALF_UP).doubleValue();
     } while (max >= Double.MAX_VALUE - buffer || min <= -Double.MAX_VALUE + buffer);
     // System.err.println("min: " + min + "   max: " + max + "   gap: " + gap + "   buffer: " + buffer);