You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/14 13:52:49 UTC

[GitHub] [apisix-dashboard] Applenice opened a new pull request #2210: fix: source codes link

Applenice opened a new pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [X] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   fix source codes link from https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/deploy.md  to https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/install.md
   
   **Checklist:**
   
   - [X] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Applenice commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
Applenice commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r749380348



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       Agree, great😄Would it be better to swap the position of Docker and RPM and keep the order of the file titles？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-976193321


   🤔 Why it fail?? @LiteSun please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Applenice commented on pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
Applenice commented on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-976168880


   Hi, can this merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r749465368



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       Sure, that's my mistake, I will change the suggested content.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Applenice commented on a change in pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
Applenice commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r751316530



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       😮I have updated once, you can see it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] 1502shivam-singh merged pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
1502shivam-singh merged pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-981123715


   > 🤔 Why it fail?? @LiteSun please take a look.
   
   @juzhiyuan This is the case of instability in the test, and it is usually sufficient to perform several retries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Applenice commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
Applenice commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r750394286



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       @juzhiyuan @bzp2010 emmm, I can't Commit suggestion now😐Can you operate it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r748874977



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       ```suggestion
   - [RPM, Docker, Source Codes](./docs/en/latest/install.md)
   - [Rebuild docker image](./docs/en/latest/deploy-with-docker.md)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r748874784



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       ```suggestion
   - [RPM, Docker, Source Codes](./docs/en/latest/install.md)
   - [Rebuild docker image](./docs/en/latest/deploy-with-docker.md)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r749465368



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       Sure, that's my mistake, I will change the suggested content. If there are no other changes, you can commit the code directly using the commit suggestion button above.
   
   ![image](https://user-images.githubusercontent.com/8078418/141814212-ed2369ba-e2b9-4c6c-af30-3d729a83c5db.png)
   

##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       Sure, that's my mistake, I will change the suggested content. If there are no other changes, you can commit the code directly using the commit suggestion button above.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-976180705


   Yes, let me rerun the failed tests first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Applenice commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
Applenice commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r749480813



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       I show here: `Applying suggestions on deleted lines is currently not supported.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-968323740


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2210](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2456c9b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ad7e3e79f47945c9ec7c042b46d48c3b2994a9fa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad7e3e7) will **increase** coverage by `2.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2210      +/-   ##
   ==========================================
   + Coverage   65.16%   68.07%   +2.91%     
   ==========================================
     Files         184      127      -57     
     Lines        7257     3352    -3905     
     Branches      824      824              
   ==========================================
   - Hits         4729     2282    -2447     
   + Misses       2244     1070    -1174     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `68.07% <ø> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   | [api/internal/core/entity/interface.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2ludGVyZmFjZS5nbw==) | | |
   | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | | |
   | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | |
   | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | |
   | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | |
   | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
   | ... and [48 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ad7e3e7...2456c9b](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r750845176



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       ![image](https://user-images.githubusercontent.com/2106987/142125386-a1f9e112-f812-4b40-bb67-82b156179a60.png)
   
   The seem warning 🤔 Could you update this PR manually?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2210: fix: source codes link

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#discussion_r748874977



##########
File path: README.md
##########
@@ -77,9 +77,9 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
+- [Source Codes](./docs/en/latest/install.md#source-source)
 - [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [RPM package（only for CentOS 7）](./docs/en/latest/install.md#rpm-rpm)

Review comment:
       ```suggestion
   - [Docker, RPM, Source Codes](./docs/en/latest/install.md)
   - [Rebuild docker image](./docs/en/latest/deploy-with-docker.md)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2210: fix: build then launch link

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-968323740


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2210](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (96a5766) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5fc0834b6bf3a37b3624fc7a4aa41623efe9562b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fc0834) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #2210   +/-   ##
   =======================================
     Coverage   68.07%   68.07%           
   =======================================
     Files         127      127           
     Lines        3352     3352           
     Branches      824      824           
   =======================================
     Hits         2282     2282           
     Misses       1070     1070           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.07% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5fc0834...96a5766](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org