You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/03 13:21:11 UTC

[GitHub] [kafka] dajac commented on a change in pull request #11560: KAFKA-7589: Allow configuring network threads per listener

dajac commented on a change in pull request #11560:
URL: https://github.com/apache/kafka/pull/11560#discussion_r761930382



##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -841,16 +974,17 @@ private[kafka] class Processor(val id: Int,
     Option(metrics.metric(metrics.metricName("io-wait-ratio", MetricsGroup, metricTags))).fold(0.0)(m =>
       Math.min(m.metricValue.asInstanceOf[Double], 1.0))
   },
+    //TODO is this an issue if we change the metrics tags?

Review comment:
       I think so because it is not backward compatible. It seems that we already kept that metrics for backward compatibility reason. I am not sure if it was deprecated at some point or not. If it would, we could perhaps drop it in a future release. Is this the only problematic metric? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org