You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:09:18 UTC
[GitHub] [flink] zentol commented on a change in pull request #19025: [FLINK-26553][build] Configure scalafmt
zentol commented on a change in pull request #19025:
URL: https://github.com/apache/flink/pull/19025#discussion_r822822807
##########
File path: pom.xml
##########
@@ -1959,6 +1959,34 @@ under the License.
<removeUnusedImports />
</java>
+ <scala>
+ <scalafmt>
+ <version>3.4.3</version>
+ <file>.scalafmt.conf</file>
+ </scalafmt>
+ <!-- license header is handled separately directly by spotless -->
+ <licenseHeader>
+ <content>/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
Review comment:
isn't this covered by the rat-plugin?
Does it automatically add the header when doing spotless:apply? If so, is this only supported for Scala?
##########
File path: pom.xml
##########
@@ -1959,6 +1959,34 @@ under the License.
<removeUnusedImports />
</java>
+ <scala>
+ <scalafmt>
+ <version>3.4.3</version>
+ <file>.scalafmt.conf</file>
+ </scalafmt>
+ <!-- license header is handled separately directly by spotless -->
+ <licenseHeader>
+ <content>/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+</content>
+ <delimiter>package </delimiter>
Review comment:
is the trailing space intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org