You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/05/01 16:15:00 UTC

[jira] [Commented] (WICKET-7052) Interrupting a task should not be logged as an error

    [ https://issues.apache.org/jira/browse/WICKET-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718271#comment-17718271 ] 

ASF GitHub Bot commented on WICKET-7052:
----------------------------------------

reckart opened a new pull request, #588:
URL: https://github.com/apache/wicket/pull/588

   - Do not log an error if a task is interrupted while sleeping
   - Do log a trace message when the task has been stopped
   
   https://issues.apache.org/jira/browse/WICKET-7052




> Interrupting a task should not be logged as an error
> ----------------------------------------------------
>
>                 Key: WICKET-7052
>                 URL: https://issues.apache.org/jira/browse/WICKET-7052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>            Reporter: Richard Eckart de Castilho
>            Priority: Minor
>
> An interrupt can be used to wake a sleeping task so it can check if it has been stopped. Since this is not an uncommon scenario, it should not be logged as an error.
> Consider for example the {{ModificationWatcher}}. On shutdown, its {{destroy}} method is called which may {{interrupt()}} the watcher task. Calling {{Task.interrupt()}} will set the {{stop}} flag in the task and then interrupt the task thread. If this happens while the task is sleeping, it should not cause an error to be logged.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)