[GitHub] [spark] zhengruifeng commented on a diff in pull request #40150: [SPARK-41834][CONNECT] Implement SparkSession.conf

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #40150:
URL: https://github.com/apache/spark/pull/40150#discussion_r1116623834


##########
python/pyspark/sql/conf.py:
##########
@@ -35,12 +35,14 @@ def __init__(self, jconf: JavaObject) -> None:
         self._jconf = jconf
 
     @since(2.0)
-    def set(self, key: str, value: str) -> None:
+    def set(self, key: str, value: Union[str, int, bool]) -> None:
         """Sets the given Spark runtime configuration property."""

Review Comment:
   if we reuse existing doc in sql, we normally add a comment like this:
   
   ```
       .. versionchanged:: 3.4.0
           Support Spark Connect.
   ```
   
   or maybe
   ```
       .. versionchanged:: 4.0.0 (or 3.5.0?)
           Support Spark Connect.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org