You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by csosborn <gi...@git.apache.org> on 2016/04/07 18:30:35 UTC
[GitHub] thrift pull request: THRIFT-3784: fix and tests
GitHub user csosborn opened a pull request:
https://github.com/apache/thrift/pull/984
THRIFT-3784: fix and tests
This patch fixes [THRIFT-3784](https://issues.apache.org/jira/browse/THRIFT-3784), a bug in the thrift-maven-plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csosborn/thrift THRIFT-3784
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/984.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #984
----
commit e5cf90e6f1d3d3e52c5c645b9fa04626176354f1
Author: Chris Osborn <co...@conductor.com>
Date: 2016-04-07T16:20:02Z
Fix and tests for THRIFT-3784.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #984: THRIFT-3784: fix and tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3784: fix and tests
Posted by csosborn <gi...@git.apache.org>.
Github user csosborn commented on a diff in the pull request:
https://github.com/apache/thrift/pull/984#discussion_r58903035
--- Diff: contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java ---
@@ -319,15 +331,6 @@ public boolean accept(File dir, String name) {
return ImmutableSet.copyOf(thriftFilesInDirectory);
}
- ImmutableSet<File> findThriftFilesInDirectories(Iterable<File> directories) throws IOException {
- checkNotNull(directories);
- Set<File> thriftFiles = newHashSet();
- for (File directory : directories) {
- thriftFiles.addAll(findThriftFilesInDirectory(directory));
- }
- return ImmutableSet.copyOf(thriftFiles);
- }
--- End diff --
This code was unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3784: fix and tests
Posted by csosborn <gi...@git.apache.org>.
Github user csosborn commented on the pull request:
https://github.com/apache/thrift/pull/984#issuecomment-207074660
What's the protocol here? It does not look like the build failures have anything to do with my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #984: THRIFT-3784: fix and tests
Posted by csosborn <gi...@git.apache.org>.
Github user csosborn commented on the issue:
https://github.com/apache/thrift/pull/984
Just checking in here.. This request has been open for about two months with no response.
Is the project still accepting patches? It doesn't look like anything has been merged in a few months, and the CI system appears unhealthy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #984: THRIFT-3784: fix and tests
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/984
The project is still accepting patches, however as you can see we have over 100 pull requests (I have 3 in the queue) but we haven't been able to stabilize the apache build job for quite some time, leading to a backlog. Only a few people have access to the apache build job and until we can get builds to pass the project lead decided (correctly, in my opinion) not to merge any more code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---