You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/04/16 13:58:06 UTC
Review Request 20412: Flume configurations should not have 'flume-conf' type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20412/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-5478
https://issues.apache.org/jira/browse/AMBARI-5478
Repository: ambari
Description
-------
When I installed Flume service I saw 2 (flume-agent and flume.conf) configurations instead of 1. The API also has configurations?type=flume-agent&tag=version1 and configurations?type=flume-conf&tag=version1.
We should only have flume-agent config. The section title should be "flume-agent.conf" and the text area will have default value of "# Flume agents configuration". When saved the changes should be persisted in "content" key of type=flume-agent.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-agent.xml cf7d07b
ambari-web/app/assets/data/clusters/tags_and_groups.json ece895d
ambari-web/app/assets/data/configurations/cluster_level_configs.json ccdfa66
ambari-web/app/controllers/wizard/step8_controller.js 231e1c2
ambari-web/app/data/HDP2/site_properties.js 3e1c230
ambari-web/app/data/service_configs.js f2bb756
ambari-web/app/utils/config.js 29444f6
Diff: https://reviews.apache.org/r/20412/diff/
Testing
-------
3289 tests complete (3 seconds)
Thanks,
Andrii Tkach
Re: Review Request 20412: Flume configurations should not have 'flume-conf'
type
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20412/#review40543
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On April 16, 2014, 11:58 a.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20412/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 11:58 a.m.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-5478
> https://issues.apache.org/jira/browse/AMBARI-5478
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When I installed Flume service I saw 2 (flume-agent and flume.conf) configurations instead of 1. The API also has configurations?type=flume-agent&tag=version1 and configurations?type=flume-conf&tag=version1.
> We should only have flume-agent config. The section title should be "flume-agent.conf" and the text area will have default value of "# Flume agents configuration". When saved the changes should be persisted in "content" key of type=flume-agent.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-agent.xml cf7d07b
> ambari-web/app/assets/data/clusters/tags_and_groups.json ece895d
> ambari-web/app/assets/data/configurations/cluster_level_configs.json ccdfa66
> ambari-web/app/controllers/wizard/step8_controller.js 231e1c2
> ambari-web/app/data/HDP2/site_properties.js 3e1c230
> ambari-web/app/data/service_configs.js f2bb756
> ambari-web/app/utils/config.js 29444f6
>
> Diff: https://reviews.apache.org/r/20412/diff/
>
>
> Testing
> -------
>
> 3289 tests complete (3 seconds)
>
>
> Thanks,
>
> Andrii Tkach
>
>