You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "dididy (via GitHub)" <gi...@apache.org> on 2025/07/12 09:12:08 UTC
[PR] [ZEPPELIN-6203] Connect shortcut for info button [zeppelin]
dididy opened a new pull request, #4963:
URL: https://github.com/apache/zeppelin/pull/4963
### What is this PR for?
<img width="417" height="103" alt="image" src="https://github.com/user-attachments/assets/d4fca2f3-0dca-43ae-b159-ca881bd1766d" />
Nothing happened when I click above info button inside of Zeppelin Notebook. So I connect this function work properly.
This button related in [here](https://github.com/apache/zeppelin/blob/526eb15b8732909ab994adba76e0c3e33bfa001c/zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts#L239) so I made shared shortcut component and connect it. Now it works well.
<img width="1624" height="1056" alt="스크린샷 2025-07-12 오후 6 10 05" src="https://github.com/user-attachments/assets/d71e7264-eefb-4e80-bf4d-cf4467627d5e" />
I refer to [zeppelin-web's shortcut file](https://github.com/apache/zeppelin/blob/526eb15b8732909ab994adba76e0c3e33bfa001c/zeppelin-web/src/app/notebook/shortcut.html)
### What type of PR is it?
Bug Fix
Feature
Refactoring
### Todos
* [ ] TBD
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6203
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? NO
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut modal for info button [zeppelin]
Posted by "dididy (via GitHub)" <gi...@apache.org>.
dididy commented on code in PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#discussion_r2327692155
##########
zeppelin-web/src/app/notebook/shortcut.html:
##########
Review Comment:
79ca7fa / 2dd2a6c
I accidentally deleted the Classic UI version instead of the New UI one. I’ve reverted that and modified it to delete the New UI version instead. Thanks for checking it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut modal for info button [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut for info button [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#issuecomment-3065031278
Yes, it would be great if we have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut modal for info button [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on code in PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#discussion_r2326883056
##########
zeppelin-web/src/app/notebook/shortcut.html:
##########
Review Comment:
Are you intending to remove the auto-completion shortcut info only from the new UI? If so, this should be reverted, as it removes the shortcut information from the classic UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut for info button [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#issuecomment-3064980297
@dididy Can we add some tests for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut modal for info button [zeppelin]
Posted by "dididy (via GitHub)" <gi...@apache.org>.
dididy commented on PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#issuecomment-3261496744
87c4d19
I added the missing `isMac` variable to detect macOS. This makes the modifier key label display as `Option` on macOS and `Alt` on other platforms.
6e75ed6
In the Classic UI, auto-completion triggered by `Control + .` had to be manually activated, but in the Monaco editor used in the NewUI, it is always enabled by default. Therefore, the shortcut is unnecessary and has been removed.
https://issues.apache.org/jira/browse/ZEPPELIN-6314
I’m currently looking into the E2E environment setup, and the Jira ticket is as above. It will likely use Playwright.
#5044 / #5064
Once the subsequent PRs are merged, I’ll review again, and this PR can be merged afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut for info button [zeppelin]
Posted by "dididy (via GitHub)" <gi...@apache.org>.
dididy commented on PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#issuecomment-3065012457
> @dididy Can we add some tests for it?
Are you referring to E2E test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6203] Connect shortcut modal for info button [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4963:
URL: https://github.com/apache/zeppelin/pull/4963#issuecomment-3263848288
Merged into master and branch-0.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org