svn commit: r967080 - in /lucene/dev/trunk/lucene/src/test/org/apache/lucene/util: LuceneTestCase.java LuceneTestCaseJ4.java

[rm...@apache.org]

Author: rmuir
Date: Fri Jul 23 12:47:25 2010
New Revision: 967080

URL: http://svn.apache.org/viewvc?rev=967080&view=rev
Log:
warn if you fix a random seed (so we dont leave the test de-randomized)

Modified:
    lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCase.java
    lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCaseJ4.java

Modified: lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCase.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCase.java?rev=967080&r1=967079&r2=967080&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCase.java (original)
+++ lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCase.java Fri Jul 23 12:47:25 2010
@@ -247,7 +247,8 @@ public abstract class LuceneTestCase ext
     if (seed != null) {
       throw new IllegalStateException("please call LuceneTestCase.newRandom only once per test");
     }
-    return newRandom(seedRnd.nextLong());
+    this.seed = Long.valueOf(seedRnd.nextLong());
+    return new Random(seed);
   }
   
   /**
@@ -259,6 +260,7 @@ public abstract class LuceneTestCase ext
     if (this.seed != null) {
       throw new IllegalStateException("please call LuceneTestCase.newRandom only once per test");
     }
+    System.out.println("WARNING: random seed of testcase '" + getName() + "' is fixed to: " + seed);
     this.seed = Long.valueOf(seed);
     return new Random(seed);
   }

Modified: lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCaseJ4.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCaseJ4.java?rev=967080&r1=967079&r2=967080&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCaseJ4.java (original)
+++ lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/LuceneTestCaseJ4.java Fri Jul 23 12:47:25 2010
@@ -323,7 +323,8 @@ public class LuceneTestCaseJ4 {
     if (seed != null) {
       throw new IllegalStateException("please call LuceneTestCaseJ4.newRandom only once per test");
     }
-    return newRandom(seedRnd.nextLong());
+    this.seed = Long.valueOf(seedRnd.nextLong());
+    return new Random(seed);
   }
 
   /**
@@ -335,6 +336,7 @@ public class LuceneTestCaseJ4 {
     if (this.seed != null) {
       throw new IllegalStateException("please call LuceneTestCaseJ4.newRandom only once per test");
     }
+    System.out.println("WARNING: random seed of testcase '" + getName() + "' is fixed to: " + seed);
     this.seed = Long.valueOf(seed);
     return new Random(seed);
   }
@@ -350,7 +352,9 @@ public class LuceneTestCaseJ4 {
    * .
    */
   public static Random newStaticRandom(Class<? extends LuceneTestCaseJ4> clazz) {
-    return newStaticRandom(clazz, seedRnd.nextLong());
+    Long seed = seedRnd.nextLong();
+    staticSeeds.put(clazz, seed);
+    return new Random(seed);
   }
   
   /**
@@ -361,6 +365,7 @@ public class LuceneTestCaseJ4 {
    */
   public static Random newStaticRandom(Class<? extends LuceneTestCaseJ4> clazz, long seed) {
     staticSeeds.put(clazz, Long.valueOf(seed));
+    System.out.println("WARNING: random static seed of testclass '" + clazz + "' is fixed to: " + seed);
     return new Random(seed);
   }