You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/02/09 05:03:40 UTC
Review Request 56471: ATLAS-1534: TypesREST clean up for simpler REST
interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56471/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1534
https://issues.apache.org/jira/browse/ATLAS-1534
Repository: atlas
Description
-------
ATLAS-1534: TypesREST clean up for simpler REST interface
Diffs
-----
client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java 0ce811bf46c235b011a6bbcb37917887159ef171
intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 95c5e6415f41d1dfd5c9aa49792826bb5a7d3cfc
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7bd8a839927deec3e744a0f9a620befbca903cc2
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 1f7adf35ebc77cbb2e40afe660eb9abcfffb2b7c
Diff: https://reviews.apache.org/r/56471/diff/
Testing
-------
mvn clean install executes successfully with few consistent IT failures.
Thanks,
Apoorv Naik
Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler
REST interface
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56471/#review164989
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java (line 44)
<https://reviews.apache.org/r/56471/#comment236822>
update*Def() should be gone as well.
update*DefByName() is needed to support renaming of types. Currently there is no usecase for this; and given typename is used in various places like edge-labels, vertex-attribute - it may not be easy to support rename. I would suggest to remove these methods now. We can revisit if there is a need later.
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java (line 68)
<https://reviews.apache.org/r/56471/#comment236825>
Consider using typeRegistry for reads - it will be more efficient than reading from typeDefStore.
- Madhan Neethiraj
On Feb. 9, 2017, 5:03 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56471/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 5:03 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1534
> https://issues.apache.org/jira/browse/ATLAS-1534
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1534: TypesREST clean up for simpler REST interface
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java 0ce811bf46c235b011a6bbcb37917887159ef171
> intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 95c5e6415f41d1dfd5c9aa49792826bb5a7d3cfc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7bd8a839927deec3e744a0f9a620befbca903cc2
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 1f7adf35ebc77cbb2e40afe660eb9abcfffb2b7c
>
> Diff: https://reviews.apache.org/r/56471/diff/
>
>
> Testing
> -------
>
> mvn clean install executes successfully with few consistent IT failures.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler
REST interface
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56471/#review165061
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java (line 230)
<https://reviews.apache.org/r/56471/#comment236907>
"getBaseTypedefByName" ==> "getTypedefByName"
"getBaseTypedefByGuid" ==> "getTypedefByGuid"
- Madhan Neethiraj
On Feb. 10, 2017, 5:11 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56471/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 5:11 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1534
> https://issues.apache.org/jira/browse/ATLAS-1534
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1534: TypesREST clean up for simpler REST interface
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java 0ce811bf
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java aed51408
> intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 95c5e641
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7bd8a839
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 3b720322
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java ed1e4946
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 1f7adf35
>
> Diff: https://reviews.apache.org/r/56471/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipITs executes successfully.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler
REST interface
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56471/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 5:59 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
Addressed review comments
Bugs: ATLAS-1534
https://issues.apache.org/jira/browse/ATLAS-1534
Repository: atlas
Description
-------
ATLAS-1534: TypesREST clean up for simpler REST interface
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java 0ce811bf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java aed51408
intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 95c5e641
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7bd8a839
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 3b720322
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java ed1e4946
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 1f7adf35
Diff: https://reviews.apache.org/r/56471/diff/
Testing
-------
mvn clean install -DskipITs executes successfully.
Thanks,
Apoorv Naik
Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler
REST interface
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56471/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 5:11 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1534
https://issues.apache.org/jira/browse/ATLAS-1534
Repository: atlas
Description
-------
ATLAS-1534: TypesREST clean up for simpler REST interface
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java 0ce811bf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java aed51408
intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 95c5e641
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7bd8a839
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 3b720322
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java ed1e4946
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 1f7adf35
Diff: https://reviews.apache.org/r/56471/diff/
Testing
-------
mvn clean install -DskipITs executes successfully.
Thanks,
Apoorv Naik
Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler
REST interface
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56471/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 2:14 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
Cleaned up few more methods in the store and added a generic get by name/guid
Bugs: ATLAS-1534
https://issues.apache.org/jira/browse/ATLAS-1534
Repository: atlas
Description
-------
ATLAS-1534: TypesREST clean up for simpler REST interface
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java 0ce811bf46c235b011a6bbcb37917887159ef171
docs/src/site/twiki/index.twiki 26157fdd4a9ede7a651d0dc53f51b2e1e535d050
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7b11b70d334a685fe951a34ba6203b3f83885059
intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 95c5e6415f41d1dfd5c9aa49792826bb5a7d3cfc
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7bd8a839927deec3e744a0f9a620befbca903cc2
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 3b720322b3a9d863391393b60f3a49a449ffedd8
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java ed1e494633bbff89e77b5ee70eac0acd5f4aa1bb
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 1f7adf35ebc77cbb2e40afe660eb9abcfffb2b7c
Diff: https://reviews.apache.org/r/56471/diff/
Testing (updated)
-------
mvn clean install -DskipITs executes successfully.
Thanks,
Apoorv Naik