[jira] [Commented] (ACCUMULO-2854) Bad null check in BulkImport.createNewBulkDir()

["Mike Drob (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030304#comment-14030304 ] 

Mike Drob commented on ACCUMULO-2854:
-------------------------------------

[~jschwartz73] - Overall, the patch looks good. Do you think you can drop the second null check (against tableDir) because it is dead code? Or am I missing a code path there?

Thanks,
Mike

> Bad null check in BulkImport.createNewBulkDir()
> -----------------------------------------------
>
>                 Key: ACCUMULO-2854
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2854
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Jeffrey S Schwartz
>              Labels: newbie, summit2014
>             Fix For: 1.6.1
>
>         Attachments: ACCUMULO-2854.patch.txt
>
>
> At the beginning of {{createNewBulkDir}} in {{o.a.a.master.tableOps.BulkImport}}:
> {code}
>     String tableDir = fs.matchingFileSystem(new Path(sourceDir), ServerConstants.getTablesDirs()).toString();
>     
>     if (tableDir == null)
>       throw new IllegalStateException(sourceDir + " is not in a known namespace");
> {code}
> The call to {{matchingFileSystem()}} can return null, and if it does, a NullPointerException will be thrown. {{toString()}} on a non-null result will not return null, so the null check has no effect.



--
This message was sent by Atlassian JIRA
(v6.2#6252)