You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/31 02:34:25 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a diff in pull request #1855: feat: Rest protocol Support

LaurenceLiZhixin commented on code in PR #1855:
URL: https://github.com/apache/dubbo-go/pull/1855#discussion_r885157132


##########
protocol/rest/rest_invoker_test.go:
##########
@@ -1,217 +1,217 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   This header changes caust ci verify failed.
   And after you fix it, run `golangci-lint run` locally to make sure it pass, as I see , now your code have linter problems: https://github.com/apache/dubbo-go/runs/6663336503?check_suite_focus=true
   @complone 



##########
protocol/rest/rest_invoker_test.go:
##########
@@ -1,217 +1,217 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   This header changes cause ci verify failed.
   And after you fix it, run `golangci-lint run` locally to make sure it pass, as I see , now your code have linter problems: https://github.com/apache/dubbo-go/runs/6663336503?check_suite_focus=true
   @complone 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org