[jira] [Commented] (LUCENE-5903) Fix MockDirectoryWrapper double-write logic?

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108432#comment-14108432 ] 

Robert Muir commented on LUCENE-5903:
-------------------------------------

I think its too hard to improve the situation for windows, its unavoidable really. The best we could probably do is gobble up extra generations on IW bootup to try to make it less likely.

As far as fixing MDW to allow for the situation (recording deleted files and checking that map), it would be nice if somehow it would only "allow" this across IW instances, but not within the same one.

> Fix MockDirectoryWrapper double-write logic?
> --------------------------------------------
>
>                 Key: LUCENE-5903
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5903
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5903_test.patch
>
>
> From a jenkins failure: 
> {quote}
> I think its a bug, and this was just exposed by randomization of
> commitOnClose in IndexWriterConfig?
> we start a CMS merge for _8 segment (consumer creates _8.fdt and
> _8.fdx), but this merge doesn't make it into the commit, and we
> close() without waiting for merges.
> this merge is aborted and indexfiledeleter cleans up _8.fdt and _8.fdx
> we start a new IW on the same dir, and the next segment it tries to
> create is _8 (how else would it know?) which trips the double-write
> logic in createOutput.
> This logic currently only checks files that we ever created, and
> doesn't check if we ever deleted the file.
> We can fix mockdirectorywrapper, but I feel like this could be a real
> problem on e.g. windows if the file was busy for both IFD runs.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org